From: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
To: git@vger.kernel.org
Cc: Jakub Narebski <jnareb@gmail.com>, Petr Baudis <pasky@suse.cz>,
Junio C Hamano <gitster@pobox.com>,
Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
Subject: [RFCv3 2/2] gitweb: links to patch action in commitdiff and shortlog view
Date: Wed, 3 Dec 2008 23:59:48 +0100 [thread overview]
Message-ID: <1228345188-15125-3-git-send-email-giuseppe.bilotta@gmail.com> (raw)
In-Reply-To: <1228345188-15125-2-git-send-email-giuseppe.bilotta@gmail.com>
In shortlog view, a link to the patchset is only offered when the number
of commits shown is less than the allowed maximum number of patches.
Signed-off-by: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
---
gitweb/gitweb.perl | 18 ++++++++++++++++++
1 files changed, 18 insertions(+), 0 deletions(-)
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index c9abfcf..ec8fc7d 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -5083,6 +5083,11 @@ sub git_commit {
} @$parents ) .
')';
}
+ if (gitweb_check_feature('patches')) {
+ $formats_nav .= " | " .
+ $cgi->a({-href => href(action=>"patch", -replay=>1)},
+ "patch");
+ }
if (!defined $parent) {
$parent = "--root";
@@ -5415,6 +5420,11 @@ sub git_commitdiff {
$formats_nav =
$cgi->a({-href => href(action=>"commitdiff_plain", -replay=>1)},
"raw");
+ if ($patch_max) {
+ $formats_nav .= " | " .
+ $cgi->a({-href => href(action=>"patch", -replay=>1)},
+ "patch");
+ }
if (defined $hash_parent &&
$hash_parent ne '-c' && $hash_parent ne '--cc') {
@@ -5949,6 +5959,14 @@ sub git_shortlog {
$cgi->a({-href => href(-replay=>1, page=>$page+1),
-accesskey => "n", -title => "Alt-n"}, "next");
}
+ my $patch_max = gitweb_check_feature('patches');
+ if ($patch_max) {
+ if ($patch_max < 0 || @commitlist <= $patch_max) {
+ $paging_nav .= " ⋅ " .
+ $cgi->a({-href => href(action=>"patch", -replay=>1)},
+ @commitlist > 1 ? "patchset" : "patch");
+ }
+ }
git_header_html();
git_print_page_nav('shortlog','', $hash,$hash,$hash, $paging_nav);
--
1.5.6.5
next prev parent reply other threads:[~2008-12-03 23:01 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-03 22:59 [RFCv3 0/2] gitweb: patch view Giuseppe Bilotta
2008-12-03 22:59 ` [RFCv3 1/2] gitweb: add " Giuseppe Bilotta
2008-12-03 22:59 ` Giuseppe Bilotta [this message]
2008-12-06 0:53 ` [RFCv3 2/2] gitweb: links to patch action in commitdiff and shortlog view Jakub Narebski
2008-12-06 13:25 ` Giuseppe Bilotta
2008-12-06 15:25 ` Jakub Narebski
2008-12-03 23:55 ` [RFCv3 1/2] gitweb: add patch view Junio C Hamano
2008-12-04 0:20 ` Giuseppe Bilotta
2008-12-04 0:40 ` Junio C Hamano
2008-12-04 1:48 ` Jakub Narebski
2008-12-04 7:24 ` Giuseppe Bilotta
2008-12-06 0:34 ` Jakub Narebski
2008-12-06 0:46 ` Junio C Hamano
2008-12-06 1:09 ` Jakub Narebski
2008-12-06 1:26 ` Junio C Hamano
2008-12-06 13:01 ` Giuseppe Bilotta
2008-12-06 13:10 ` Petr Baudis
2008-12-06 12:34 ` Giuseppe Bilotta
2008-12-06 13:09 ` Jakub Narebski
2008-12-06 13:46 ` Giuseppe Bilotta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1228345188-15125-3-git-send-email-giuseppe.bilotta@gmail.com \
--to=giuseppe.bilotta@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jnareb@gmail.com \
--cc=pasky@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).