From: "Shawn O. Pearce" <spearce@spearce.org>
To: Robin Rosenberg <robin.rosenberg@dewire.com>
Cc: git@vger.kernel.org
Subject: [JGIT PATCH 0/6] RawParseUtil improvements
Date: Wed, 10 Dec 2008 14:05:45 -0800 [thread overview]
Message-ID: <1228946751-12708-1-git-send-email-spearce@spearce.org> (raw)
I'm working on patch parsing support for JGit, so I can rely on
it in Gerrit 2. Currently Gerrit 1 uses a bastard chunk of code
I ripped out in an hour to scan the output of "git diff"; its not
suitable for long-term appliction.
This series improves RawParseUtils code clarity, and then adds
support for the C-style quoting rules used by git diff when file
names contain "special" characters like LF.
I'm working on patch parsing right now; but I wanted to send this
preliminary series out so you aren't drowning in code to review.
Shawn O. Pearce (6):
Simplify RawParseUtils.nextLF invocations
Simplify RawParseUtils next and nextLF loops
Correct Javadoc of RawParseUtils next and nextLF methods
Add QuotedString class to handle C-style quoting rules
Add Bourne style quoting for TransportGitSsh
Add ~user friendly Bourne style quoting for TransportGitSsh
.../jgit/util/QuotedStringBourneStyleTest.java | 111 ++++++
.../util/QuotedStringBourneUserPathStyleTest.java | 130 +++++++
.../spearce/jgit/util/QuotedStringC_StyleTest.java | 144 ++++++++
.../src/org/spearce/jgit/lib/ObjectChecker.java | 4 +-
.../src/org/spearce/jgit/revwalk/RevTag.java | 2 +-
.../spearce/jgit/transport/TransportGitSsh.java | 38 +--
.../src/org/spearce/jgit/util/QuotedString.java | 364 ++++++++++++++++++++
.../src/org/spearce/jgit/util/RawParseUtils.java | 45 ++-
8 files changed, 783 insertions(+), 55 deletions(-)
create mode 100644 org.spearce.jgit.test/tst/org/spearce/jgit/util/QuotedStringBourneStyleTest.java
create mode 100644 org.spearce.jgit.test/tst/org/spearce/jgit/util/QuotedStringBourneUserPathStyleTest.java
create mode 100644 org.spearce.jgit.test/tst/org/spearce/jgit/util/QuotedStringC_StyleTest.java
create mode 100644 org.spearce.jgit/src/org/spearce/jgit/util/QuotedString.java
next reply other threads:[~2008-12-10 22:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-10 22:05 Shawn O. Pearce [this message]
2008-12-10 22:05 ` [JGIT PATCH 1/6] Simplify RawParseUtils.nextLF invocations Shawn O. Pearce
2008-12-10 22:05 ` [JGIT PATCH 2/6] Simplify RawParseUtils next and nextLF loops Shawn O. Pearce
2008-12-10 22:05 ` [JGIT PATCH 3/6] Correct Javadoc of RawParseUtils next and nextLF methods Shawn O. Pearce
2008-12-10 22:05 ` [JGIT PATCH 4/6] Add QuotedString class to handle C-style quoting rules Shawn O. Pearce
2008-12-10 22:05 ` [JGIT PATCH 5/6] Add Bourne style quoting for TransportGitSsh Shawn O. Pearce
2008-12-10 22:05 ` [JGIT PATCH 6/6] Add ~user friendly " Shawn O. Pearce
2008-12-10 23:22 ` [JGIT PATCH 4/6] Add QuotedString class to handle C-style quoting rules Robin Rosenberg
2008-12-10 23:41 ` Shawn O. Pearce
2008-12-11 0:33 ` Robin Rosenberg
2008-12-11 0:57 ` [JGIT PATCH 4/6 v3] Add QuotedString class to handle Git path style " Shawn O. Pearce
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1228946751-12708-1-git-send-email-spearce@spearce.org \
--to=spearce@spearce.org \
--cc=git@vger.kernel.org \
--cc=robin.rosenberg@dewire.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).