git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Charles Bailey <charles@hashpling.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Jeff King <peff@peff.net>,
	Andreas Ericsson <ae@op5.se>, "Theodore Ts'o" <tytso@mit.edu>,
	William Pursell <bill.pursell@gmail.com>
Subject: Updates to the previous mergetool patches
Date: Fri, 12 Dec 2008 21:48:39 +0000	[thread overview]
Message-ID: <1229118521-22923-1-git-send-email-charles@hashpling.org> (raw)

These two patches go on top of 682b451f and replace the 'DONTMERGE'
commit: 09b511016. If it would be easier if I cooked these in a
different way then let me know.

I've implemented a replacement for the "keep going" option which is now
to prompt after a failed merge to see if the user wants to continue
merging the remaining paths. This gets rid of a need for an option of
configuration option.

I haven't implemented any change to the logic as to whether to pause
before invoking the merge tool based on which merge tool is being used.

The added tests for the return status of the merge are slightly less
neat than I would have liked, but I think are necessary. I test after
invoking the merge tool to make sure that the "roll-up" status is
correct, and before invoking the next tool to see if the user wants to
continue despite the failure of the previous merge.

Only testing after the merge tool invocation can end up with a "do you
want to continue" before mergetool has determined that there are, in
fact, no more files to merge. Only testing before the merge means that
the status of the last merge doesn't contribute to the script's return
value. I don't know how many people rely on the return value of git
mergetool, but why not keep it consistent?

The second patch makes optional the retention of temporary files on a
failed merge optional. It seperates out the behaviour change that I'd
forgotten I'd left in the previous version of the "-k" patch.

             reply	other threads:[~2008-12-12 21:50 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-12 21:48 Charles Bailey [this message]
2008-12-12 21:48 ` [PATCH 1/2] mergetool: Add prompt to continue after failing to merge a file Charles Bailey
2008-12-12 21:48   ` [PATCH 2/2] mergetool: Don't keep temporary merge files unless told to Charles Bailey
2008-12-12 22:11     ` Jakub Narebski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1229118521-22923-1-git-send-email-charles@hashpling.org \
    --to=charles@hashpling.org \
    --cc=ae@op5.se \
    --cc=bill.pursell@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=peff@peff.net \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).