From: "R. Tyler Ballance" <tyler@slide.com>
To: git@vger.kernel.org
Subject: Dynamically adjusting packed_git_window_size
Date: Sun, 21 Dec 2008 15:37:32 -0600 [thread overview]
Message-ID: <1229895454-19498-1-git-send-email-tyler@slide.com> (raw)
Internally we are using a custom build of Git, and one of the patches
that I apply to newer builds of Git is one to adjust the
DEFAULT_PACKED_GIT_WINDOW_SIZE in git-compat-util.h so Git won't trample
all over our ulimit values on the 64-bit dev machines.
To do away with this, I've got these two (really one) set of patches to
adjust the packed_git_window_size when setup_git_env() is called to a
fraction of the "addressspace" limit (RLIMIT_AS). If the user's
environment defines "ulimit -v" as "unlimited", this code will not take
effect.
It's worth noting that this doesn't force Git to respect these limits,
I'm still tracking down an issue hiding in get_revision() where I'm
experiencing mmap(2) failures executing a `git log` command with
restrictive ulimit settings (Linus, since you were so "pleased" with my
last epic gdb fail, here's today's):
(gdb)
open_packed_git (p=0x71f2e0) at sha1_file.c:733
733 /* We leave these file descriptors open with sliding mmap;
(gdb)
735 */
(gdb)
741 return error("cannot set FD_CLOEXEC");
(gdb)
746 if (hdr.hdr_signature != htonl(PACK_SIGNATURE))
(gdb)
Recursive internal problem.
[1] 17381 abort GIT_PAGER= gdb git
tyler@starfruit:~/source/git/main>
Oi vei.
Cheers,
-R. Tyler Ballance
next reply other threads:[~2008-12-21 21:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-21 21:37 R. Tyler Ballance [this message]
2008-12-21 21:37 ` [PATCH] Add support for changing packed_git_window_size at process start time R. Tyler Ballance
2008-12-21 21:37 ` [PATCH] Style changes per suggestions from Junio in #git R. Tyler Ballance
2008-12-21 22:03 ` Matthieu Moy
2008-12-21 22:22 ` Shawn O. Pearce
2008-12-21 22:28 ` [PATCH] Add support for changing packed_git_window_size at process start time Shawn O. Pearce
2008-12-22 6:25 ` R. Tyler Ballance
2008-12-26 21:36 ` Shawn O. Pearce
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1229895454-19498-1-git-send-email-tyler@slide.com \
--to=tyler@slide.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).