From: "Adeodato Simó" <dato@net.com.org.es>
To: git@vger.kernel.org, gitster@pobox.com
Cc: "Adeodato Simó" <dato@net.com.org.es>
Subject: [PATCH] t7500-commit.sh: do not call test_set_editor unnecessarily, it's confusing
Date: Mon, 29 Dec 2008 10:24:18 +0100 [thread overview]
Message-ID: <1230542658-9758-1-git-send-email-dato@net.com.org.es> (raw)
Signed-off-by: Adeodato Simó <dato@net.com.org.es>
---
I was reading this test case, and it took a small bit to figure out the
editor was not being used at all. I hope there was no hidden reason for
it to be there, and it can go away.
Cheers,
t/t7500-commit.sh | 5 +----
1 files changed, 1 insertions(+), 4 deletions(-)
diff --git a/t/t7500-commit.sh b/t/t7500-commit.sh
index 6e18a96..5998baf 100755
--- a/t/t7500-commit.sh
+++ b/t/t7500-commit.sh
@@ -149,10 +149,7 @@ EOF
test_expect_success '--signoff' '
echo "yet another content *narf*" >> foo &&
- echo "zort" | (
- test_set_editor "$TEST_DIRECTORY"/t7500/add-content &&
- git commit -s -F - foo
- ) &&
+ echo "zort" | git commit -s -F - foo &&
git cat-file commit HEAD | sed "1,/^$/d" > output &&
test_cmp expect output
'
--
1.6.1.307.g07803
next reply other threads:[~2008-12-29 9:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-29 9:24 Adeodato Simó [this message]
2008-12-29 9:46 ` [PATCH] t7500-commit.sh: do not call test_set_editor unnecessarily, it's confusing Junio C Hamano
2008-12-29 9:52 ` Adeodato Simó
2008-12-29 9:57 ` Junio C Hamano
2008-12-30 12:04 ` Johannes Schindelin
2009-01-09 17:30 ` [PATCH v2] t7501-commit.sh: explicitly check that -F prevents invoking the editor Adeodato Simó
2009-01-10 10:19 ` Johannes Schindelin
2009-01-10 10:32 ` Adeodato Simó
2009-01-10 11:48 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1230542658-9758-1-git-send-email-dato@net.com.org.es \
--to=dato@net.com.org.es \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).