* [PATCH] Git.pm: let a false Directory parameter be used correctly by the constructor
@ 2009-01-02 8:49 Philippe Bruhat (BooK)
0 siblings, 0 replies; only message in thread
From: Philippe Bruhat (BooK) @ 2009-01-02 8:49 UTC (permalink / raw)
To: git; +Cc: gitster, Philippe Bruhat (BooK)
The repository constructor mistakenly rewrote a Directory parameter that
Perl happens to evaluate to false (e.g. "0") to ".".
Signed-off-by: Philippe Bruhat (BooK) <book@cpan.org>
---
perl/Git.pm | 7 ++++---
1 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/perl/Git.pm b/perl/Git.pm
index 8392a68..ad0f530 100644
--- a/perl/Git.pm
+++ b/perl/Git.pm
@@ -166,11 +166,12 @@ sub repository {
}
}
- if (not defined $opts{Repository} and not defined $opts{WorkingCopy}) {
- $opts{Directory} ||= '.';
+ if (not defined $opts{Repository} and not defined $opts{WorkingCopy}
+ and not defined $opts{Directory}) {
+ $opts{Directory} = '.';
}
- if ($opts{Directory}) {
+ if (defined $opts{Directory}) {
-d $opts{Directory} or throw Error::Simple("Directory not found: $!");
my $search = Git->repository(WorkingCopy => $opts{Directory});
--
1.6.0.3.517.g759a
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2009-01-02 8:50 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-01-02 8:49 [PATCH] Git.pm: let a false Directory parameter be used correctly by the constructor Philippe Bruhat (BooK)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).