From: "Nathan W. Panike" <nathan.panike@gmail.com>
To: git@vger.kernel.org
Cc: "Nathan W. Panike" <nathan.panike@gmail.com>
Subject: [PATCH] Get format-patch to show first commit after root commit
Date: Fri, 9 Jan 2009 15:33:07 -0600 [thread overview]
Message-ID: <1231536787-20685-1-git-send-email-nathan.panike@gmail.com> (raw)
Rework this patch to try to handle the case where one does
git format-patch -n ...
and n is a number larger than 1. Currently, the command
git format-patch -1 e83c5163316f89bfbde
in the git repository creates an empty file. Instead, one is
forced to do
git format-patch -1 --root e83c5163316f89bfbde
This seems arbitrary. This patch fixes this case, so that
git format-patch -1 e83c5163316f89bfbde
will produce an actual patch.
Signed-off-by: Nathan W. Panike <nathan.panike@gmail.com>
---
builtin-log.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/builtin-log.c b/builtin-log.c
index 4a02ee9..0eca15f 100644
--- a/builtin-log.c
+++ b/builtin-log.c
@@ -975,6 +975,9 @@ int cmd_format_patch(int argc, const char **argv, const char *prefix)
nr++;
list = xrealloc(list, nr * sizeof(list[0]));
list[nr - 1] = commit;
+ if(!commit->parents){
+ rev.show_root_diff=1;
+ }
}
total = nr;
if (!keep_subject && auto_number && total > 1)
--
1.6.1.76.gc123b.dirty
next reply other threads:[~2009-01-09 21:34 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-09 21:33 Nathan W. Panike [this message]
2009-01-10 0:49 ` [PATCH] Get format-patch to show first commit after root commit Junio C Hamano
2009-01-10 1:37 ` Nathan W. Panike
2009-01-10 11:36 ` Alexander Potashev
2009-01-10 11:39 ` [PATCH] format-patch: avoid generation of empty patches Alexander Potashev
2009-01-10 16:01 ` Nathan W. Panike
2009-01-10 16:17 ` Alexander Potashev
2009-01-10 18:07 ` Nathan W. Panike
2009-01-10 20:41 ` Junio C Hamano
2009-01-10 16:39 ` [PATCH] Add new testcases for format-patch root commits Alexander Potashev
2009-01-10 18:33 ` Alexander Potashev
-- strict thread matches above, loose matches on Subject: below --
2009-01-09 19:35 [PATCH] Get format-patch to show first commit after root commit Nathan W. Panike
2009-01-09 20:29 ` Alexander Potashev
2009-01-09 19:02 (unknown) nathan.panike
2009-01-10 10:27 ` [PATCH] Get format-patch to show first commit after root commit Johannes Schindelin
2009-01-10 10:35 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1231536787-20685-1-git-send-email-nathan.panike@gmail.com \
--to=nathan.panike@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).