git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
To: git@vger.kernel.org
Cc: Jakub Narebski <jnareb@gmail.com>,
	Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
Subject: [PATCH] gitweb: check if-modified-since for feeds
Date: Sun, 25 Jan 2009 23:42:50 +0100	[thread overview]
Message-ID: <1232923370-4427-2-git-send-email-giuseppe.bilotta@gmail.com> (raw)
In-Reply-To: <1232923370-4427-1-git-send-email-giuseppe.bilotta@gmail.com>

Offering Last-modified header for feeds is only half the work: we should
also check that same date against If-modified-since, and bail out early
with 304 Not Modified.
---
 gitweb/gitweb.perl |   20 +++++++++++++++++++-
 1 files changed, 19 insertions(+), 1 deletions(-)

diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index 8c49c75..0a5d229 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -6015,7 +6015,25 @@ sub git_feed {
 	}
 	if (defined($commitlist[0])) {
 		%latest_commit = %{$commitlist[0]};
-		%latest_date   = parse_date($latest_commit{'committer_epoch'});
+		my $latest_epoch = $latest_commit{'committer_epoch'};
+		%latest_date   = parse_date($latest_epoch);
+		my $if_modified = $cgi->http('IF_MODIFIED_SINCE');
+		if (defined $if_modified) {
+			my $since;
+			if (eval { require HTTP::Date; 1; }) {
+				$since = HTTP::Date::str2time($if_modified);
+			} elsif (eval { require Time::ParseDate; 1; }) {
+				$since = Time::ParseDate::parsedate($if_modified, GMT => 1);
+			}
+			if (defined $since && $latest_epoch <= $since) {
+				print $cgi->header(
+					-type => $content_type,
+					-charset => 'utf-8',
+					-last_modified => $latest_date{'rfc2822'},
+					-status => 304);
+				return;
+			}
+		}
 		print $cgi->header(
 			-type => $content_type,
 			-charset => 'utf-8',
-- 
1.5.6.5

  reply	other threads:[~2009-01-25 22:44 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-23  4:48 [PATCH 0/4] gitweb feed metadata tuneups Giuseppe Bilotta
2009-01-23  4:48 ` [PATCH 1/4] gitweb: channel image in rss feed Giuseppe Bilotta
2009-01-23  4:48   ` [PATCH 2/4] gitweb: feed generator metadata Giuseppe Bilotta
2009-01-23  4:48     ` [PATCH 3/4] gitweb: rss feed managingEditor Giuseppe Bilotta
2009-01-23  4:48       ` [PATCH 4/4] gitweb: rss channel date Giuseppe Bilotta
2009-01-25 22:42         ` [PATCH] gitweb: last-modified time should be commiter, not author Giuseppe Bilotta
2009-01-25 22:42           ` Giuseppe Bilotta [this message]
2009-01-26  2:18             ` [PATCH] gitweb: check if-modified-since for feeds Jakub Narebski
2009-01-26 11:25               ` Giuseppe Bilotta
2009-02-02 22:28                 ` Jakub Narebski
2009-01-26  1:54           ` [PATCH] gitweb: last-modified time should be commiter, not author Jakub Narebski
2009-01-26 11:43             ` Giuseppe Bilotta
2009-01-24 16:02 ` [PATCH 0/4] gitweb feed metadata tuneups Jakub Narebski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1232923370-4427-2-git-send-email-giuseppe.bilotta@gmail.com \
    --to=giuseppe.bilotta@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=jnareb@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).