* [PATCH JGIT] simplify loop with if and do while
@ 2009-01-31 14:25 Yann Simon
0 siblings, 0 replies; only message in thread
From: Yann Simon @ 2009-01-31 14:25 UTC (permalink / raw)
To: Shawn O. Pearce, Robin Rosenberg; +Cc: git
replace if(condition) { do { } while (condition) } by while (condition)
{ }
Signed-off-by: Yann Simon <yann.simon.fr@gmail.com>
---
.../src/org/spearce/jgit/lib/Repository.java | 18
+++++++-----------
1 files changed, 7 insertions(+), 11 deletions(-)
diff --git a/org.spearce.jgit/src/org/spearce/jgit/lib/Repository.java
b/org.spearce.jgit/src/org/spearce/jgit/lib/Repository.java
index 038a869..b6efac1 100644
--- a/org.spearce.jgit/src/org/spearce/jgit/lib/Repository.java
+++ b/org.spearce.jgit/src/org/spearce/jgit/lib/Repository.java
@@ -247,11 +247,9 @@ public File toFile(final AnyObjectId objectId) {
public boolean hasObject(final AnyObjectId objectId) {
final PackFile[] packs = packs();
int k = packs.length;
- if (k > 0) {
- do {
- if (packs[--k].hasObject(objectId))
- return true;
- } while (k > 0);
+ while (k > 0) {
+ if (packs[--k].hasObject(objectId))
+ return true;
}
return toFile(objectId).isFile();
}
@@ -288,12 +286,10 @@ public ObjectLoader openObject(final WindowCursor
curs, final AnyObjectId id)
throws IOException {
final PackFile[] packs = packs();
int k = packs.length;
- if (k > 0) {
- do {
- final ObjectLoader ol = packs[--k].get(curs, id);
- if (ol != null)
- return ol;
- } while (k > 0);
+ while (k > 0) {
+ final ObjectLoader ol = packs[--k].get(curs, id);
+ if (ol != null)
+ return ol;
}
try {
return new UnpackedObjectLoader(this, id);
--
1.6.0.6
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2009-01-31 14:26 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-01-31 14:25 [PATCH JGIT] simplify loop with if and do while Yann Simon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).