git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Sixt <j6t@kdbg.org>
To: rene.scharfe@lsrfire.ath.cx
Cc: Git Mailing List <git@vger.kernel.org>,
	Junio C Hamano <gitster@pobox.com>, Johannes Sixt <j6t@kdbg.org>
Subject: [PATCH 0/5] Consolidate path normalization functions
Date: Sat,  7 Feb 2009 16:08:26 +0100	[thread overview]
Message-ID: <1234019311-6449-1-git-send-email-j6t@kdbg.org> (raw)
In-Reply-To: <498CAF73.6050409@lsrfire.ath.cx>

This series:

 - moves sanitary_path_copy around, which accounts for the bulk
   of the change;

 - updates longest_ancestor_length(), the core function of
   GIT_CEILING_DIRECTORIES;

 - adjust the test suite, uncovers a buglet in sanitary_path_copy(),
   and fixes it.

 - removes normalize_absolute_path() that duplicated functionality
   of sanitary_path_copy().

As a side effect, this fixes GIT_CEILING_DIRECTORIES on Windows, where
this feature is currently broken.

Johannes Sixt (4):
  Make test-path-utils more robust against incorrect use
  Move sanitary_path_copy() to path.c and rename it to
    normalize_path_copy()
  Test and fix normalize_path_copy()
  Remove unused normalize_absolute_path()

René Scharfe (1):
  Fix t1504 on Windows

 cache.h                 |    2 +-
 path.c                  |  124 ++++++++++++++++++++++++++-------------
 setup.c                 |   88 +---------------------------
 t/t0060-path-utils.sh   |   33 +++++-----
 t/t1504-ceiling-dirs.sh |    6 +-
 test-path-utils.c       |   14 +++-
 6 files changed, 115 insertions(+), 152 deletions(-)

  reply	other threads:[~2009-02-07 15:17 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-04 23:00 [PATCH] fix crash in path.c on Windows René Scharfe
2009-02-04 23:51 ` Junio C Hamano
2009-02-05  7:57 ` Johannes Sixt
2009-02-05 16:48   ` René Scharfe
2009-02-05 17:13     ` Johannes Sixt
2009-02-05 20:41     ` Robin Rosenberg
2009-02-05 19:35 ` [PATCH] fix t1504 " René Scharfe
2009-02-06 12:55   ` Johannes Sixt
2009-02-06 13:11     ` Johannes Schindelin
2009-02-06 13:17       ` Johannes Sixt
2009-02-06 13:26         ` Johannes Schindelin
2009-02-06 13:36           ` Johannes Sixt
2009-02-06 17:18     ` René Scharfe
2009-02-06 19:23       ` Johannes Sixt
2009-02-06 21:45         ` René Scharfe
2009-02-07 15:08           ` Johannes Sixt [this message]
2009-02-07 15:08             ` [PATCH 1/5] Make test-path-utils more robust against incorrect use Johannes Sixt
2009-02-07 15:08               ` [PATCH 2/5] Move sanitary_path_copy() to path.c and rename it to normalize_path_copy() Johannes Sixt
2009-02-07 15:08                 ` [PATCH 3/5] Fix GIT_CEILING_DIRECTORIES on Windows Johannes Sixt
2009-02-07 15:08                   ` [PATCH 4/5] Test and fix normalize_path_copy() Johannes Sixt
2009-02-07 15:08                     ` [PATCH 5/5] Remove unused normalize_absolute_path() Johannes Sixt
2009-02-08  0:08                     ` [PATCH 4/5] Test and fix normalize_path_copy() Robin Rosenberg
2009-02-08  8:52                       ` Johannes Sixt
2009-02-08 14:46                     ` René Scharfe
2009-02-08 15:50                       ` Johannes Sixt
2009-02-07  0:25     ` [PATCH] fix t1504 on Windows René Scharfe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1234019311-6449-1-git-send-email-j6t@kdbg.org \
    --to=j6t@kdbg.org \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=rene.scharfe@lsrfire.ath.cx \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).