git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Deskin Miller <deskinm@umich.edu>
To: normalperson@yhbt.net
Cc: gitster@pobox.com, git@vger.kernel.org,
	Deskin Miller <deskinm@umich.edu>
Subject: [PATCH v2] git-svn: Print revision while searching for earliest use of path
Date: Sun,  8 Feb 2009 19:33:18 -0500	[thread overview]
Message-ID: <1234139598-13703-1-git-send-email-deskinm@umich.edu> (raw)
In-Reply-To: <86d4c5e00902050542n74b10bfdw5e9249ac23fdc9e7@mail.gmail.com>

When initializing a git-svn repository from a Subversion repoository,
it is common to be interested in a path which did not exist in the
initial commit to Subversion.  In a large repository, the initial fetch
may take some looking for the earliest existence of the path time while
the user receives no additional feedback.  Print the highest revision
number scanned thus far to let the user know something is still
happening.

Signed-off-by: Deskin Miller <deskinm@umich.edu>
---
I'd never looked closely enough at gs_fetch_loop_common to grok what was
going on, and my previous experience with svn's get_log led me to think
that git-svn would slurp up log info for all commits at once.  Silly of
me.

Eric, things are much cleaner doing as you suggest.  I added a
carriage-return at the end of the message because I like it that way,
and the line will be overwritten once it actually starts fetching data
from svn.  I don't feel strongly about it though, so if it's better to
make it a newline, please feel free to change it and apply.

Deskin Miller

 git-svn.perl |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/git-svn.perl b/git-svn.perl
index 79888a0..601e2a3 100755
--- a/git-svn.perl
+++ b/git-svn.perl
@@ -4348,6 +4348,9 @@ sub gs_fetch_loop_common {
 		}
 		$self->get_log([$longest_path], $min, $max, 0, 1, 1,
 		               sub { $revs{$_[1]} = _cb(@_) });
+		if ($err) {
+			print "Checked through r$max\r";
+		}
 		if ($err && $max >= $head) {
 			print STDERR "Path '$longest_path' ",
 				     "was probably deleted:\n",
-- 
1.6.1.399.g0d272

  reply	other threads:[~2009-02-09  0:34 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-05  5:09 [PATCH] git-svn: Print revision while searching for earliest use of path Deskin Miller
2009-02-05  6:42 ` Eric Wong
     [not found]   ` <86d4c5e00902050540lf8a3adfq18b1fed909d6e68a@mail.gmail.com>
2009-02-05 13:42     ` Deskin Miller
2009-02-09  0:33       ` Deskin Miller [this message]
2009-02-09 21:22         ` [PATCH v2] " Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1234139598-13703-1-git-send-email-deskinm@umich.edu \
    --to=deskinm@umich.edu \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=normalperson@yhbt.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).