From: Ted Pavlic <ted@tedpavlic.com>
To: spearce@spearce.org
Cc: git@vger.kernel.org, gitster@pobox.com, Ted Pavlic <ted@tedpavlic.com>
Subject: [PATCH 0/4] completion: Fixes and better non-work-tree support
Date: Wed, 11 Feb 2009 13:03:22 -0500 [thread overview]
Message-ID: <1234375406-27099-1-git-send-email-ted@tedpavlic.com> (raw)
The first patch has already been Acked by spearce.
The second patch uses a consistent "if..." convention throughout the
completion script.
The third patch improves how the __git_ps1 works when (a) the CWD is a
git dir and (b) when the CWD has a .git but no .git/HEAD.
The fourth patch fixes unbound variable errors by replacing $__vars with
${__var-}s.
Ted Pavlic (4):
completion: For consistency, changed "git rev-parse" to __gitdir
calls.
completion: Use consistent if [...] convention. No test.
completion: Better __git_ps1 support when not in working directory
completion: More fixes to prevent unbound variable errors.
contrib/completion/git-completion.bash | 75 ++++++++++++++++----------------
1 files changed, 37 insertions(+), 38 deletions(-)
next reply other threads:[~2009-02-11 18:05 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-11 18:03 Ted Pavlic [this message]
2009-02-11 18:03 ` [PATCH 1/4] completion: For consistency, changed "git rev-parse" to __gitdir calls Ted Pavlic
2009-02-11 18:03 ` [PATCH 2/4] completion: Use consistent if [...] convention. No test Ted Pavlic
2009-02-11 18:03 ` [PATCH 3/4] completion: Better __git_ps1 support when not in working directory Ted Pavlic
2009-02-11 18:03 ` [PATCH 4/4] completion: More fixes to prevent unbound variable errors Ted Pavlic
2009-02-11 18:09 ` Shawn O. Pearce
2009-02-11 18:09 ` [PATCH 3/4] completion: Better __git_ps1 support when not in working directory Shawn O. Pearce
2009-02-11 18:07 ` [PATCH 2/4] completion: Use consistent if [...] convention. No test Shawn O. Pearce
2009-02-11 18:26 ` Junio C Hamano
2009-02-11 18:35 ` Shawn O. Pearce
2009-02-11 18:14 ` Junio C Hamano
2009-02-11 18:43 ` Ted Pavlic
2009-02-11 22:25 ` Jeff King
2009-02-11 18:54 ` [PATCH 0/4] completion fixes: Acks, whitespace, and r="" Ted Pavlic
2009-02-11 18:54 ` [PATCH 1/4] completion: For consistency, changed "git rev-parse" to __gitdir calls Ted Pavlic
2009-02-11 18:54 ` [PATCH 2/4] completion: Use consistent if [...] convention. No test Ted Pavlic
2009-02-11 18:54 ` [PATCH 3/4] completion: Better __git_ps1 support when not in working directory Ted Pavlic
2009-02-11 18:54 ` [PATCH 4/4] completion: More fixes to prevent unbound variable errors Ted Pavlic
2009-02-20 17:01 ` [PATCH 0/4] completion fixes: Acks, whitespace, and r="" Ted Pavlic
2009-02-20 17:08 ` Thomas Rast
2009-02-20 17:18 ` Ted Pavlic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1234375406-27099-1-git-send-email-ted@tedpavlic.com \
--to=ted@tedpavlic.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).