From: Jay Soffian <jaysoffian@gmail.com>
To: git@vger.kernel.org
Cc: Jay Soffian <jaysoffian@gmail.com>,
peff@peff.net, gitster@pobox.com, barkalow@iabervon.org
Subject: [PATCH 4/4] builtin-remote: add set-head verb
Date: Fri, 13 Feb 2009 03:54:35 -0500 [thread overview]
Message-ID: <1234515275-91263-5-git-send-email-jaysoffian@gmail.com> (raw)
In-Reply-To: <1234515275-91263-4-git-send-email-jaysoffian@gmail.com>
Provide a porcelain command for setting/deleting
$GIT_DIR/remotes/<remote>/HEAD.
While we're at it, document what $GIT_DIR/remotes/<remote>/HEAD is all
about.
Signed-off-by: Jay Soffian <jaysoffian@gmail.com>
---
Documentation/git-remote.txt | 20 ++++++++++-
builtin-remote.c | 54 +++++++++++++++++++++++++++++++-
contrib/completion/git-completion.bash | 2 +-
3 files changed, 72 insertions(+), 4 deletions(-)
diff --git a/Documentation/git-remote.txt b/Documentation/git-remote.txt
index fad983e..80f2cfe 100644
--- a/Documentation/git-remote.txt
+++ b/Documentation/git-remote.txt
@@ -13,6 +13,7 @@ SYNOPSIS
'git remote add' [-t <branch>] [-m <master>] [-f] [--mirror] <name> <url>
'git remote rename' <old> <new>
'git remote rm' <name>
+'git remote set-head' <name> [-a | -d | <branch>]
'git remote show' [-n] <name>
'git remote prune' [-n | --dry-run] <name>
'git remote update' [group]
@@ -53,8 +54,7 @@ is created. You can give more than one `-t <branch>` to track
multiple branches without grabbing all branches.
+
With `-m <master>` option, `$GIT_DIR/remotes/<name>/HEAD` is set
-up to point at remote's `<master>` branch instead of whatever
-branch the `HEAD` at the remote repository actually points at.
+up to point at remote's `<master>` branch. See also the set-head command.
+
In mirror mode, enabled with `\--mirror`, the refs will not be stored
in the 'refs/remotes/' namespace, but in 'refs/heads/'. This option
@@ -76,6 +76,22 @@ the configuration file format.
Remove the remote named <name>. All remote tracking branches and
configuration settings for the remote are removed.
+'set-head'::
+
+Sets or deletes the default branch (`$GIT_DIR/remotes/<name>/HEAD`) for
+the named remote. Having a default branch for a remote is not required,
+but allows the name of the remote to be specified in lieu of a specific
+branch. For example, if the default branch for `origin` is set to
+`master`, then `origin` may be specified wherever you would normally
+specify `origin/master`.
++
+With `-d`, `$GIT_DIR/remotes/<name>/HEAD` is deleted.
++
+With `-a`, the remote is queried to determine its `HEAD`, then
+`$GIT_DIR/remotes/<name>/HEAD` is set to the same branch.
++
+Use `<branch>` to set `$GIT_DIR/remotes/<name>/HEAD` explicitly.
+
'show'::
Gives some information about the remote <name>.
diff --git a/builtin-remote.c b/builtin-remote.c
index 465c87a..677e20e 100644
--- a/builtin-remote.c
+++ b/builtin-remote.c
@@ -12,6 +12,7 @@ static const char * const builtin_remote_usage[] = {
"git remote add [-t <branch>] [-m <master>] [-f] [--mirror] <name> <url>",
"git remote rename <old> <new>",
"git remote rm <name>",
+ "git remote set-head <name> [-a | -d | <branch>]",
"git remote show [-n] <name>",
"git remote prune [-n | --dry-run] <name>",
"git remote [-v | --verbose] update [group]",
@@ -658,7 +659,8 @@ static void free_remote_ref_states(struct ref_states *states)
string_list_clear(&states->new, 0);
string_list_clear(&states->stale, 0);
string_list_clear(&states->tracked, 0);
- free(states->head_name);
+ if (states->head_name)
+ free(states->head_name);
}
static int get_remote_ref_states(const char *name,
@@ -777,6 +779,54 @@ static int show(int argc, const char **argv)
return result;
}
+static int sethead(int argc, const char **argv)
+{
+ int opt_a = 0, opt_d = 0, result = 0;
+ struct strbuf buf = STRBUF_INIT, buf2 = STRBUF_INIT;
+ char *head_name = NULL;
+
+ struct option options[] = {
+ OPT_GROUP("set-head specific options"),
+ OPT_BOOLEAN('a', 0, &opt_a,
+ "set refs/remotes/<name>/HEAD according to remote"),
+ OPT_BOOLEAN('d', 0, &opt_d, "delete refs/remotes/<name>/HEAD"),
+ OPT_END()
+ };
+ argc = parse_options(argc, argv, options, builtin_remote_usage, 0);
+ if ((argc == 1 && !(opt_a || opt_d)) ||
+ ((argc == 2 && (opt_a || opt_d))) || argc < 1 || argc > 2)
+ usage_with_options(builtin_remote_usage, options);
+
+ strbuf_addf(&buf, "refs/remotes/%s/HEAD", argv[0]);
+
+ if (opt_d) {
+ if (result |= delete_ref(buf.buf, NULL, REF_NODEREF))
+ error("Could not delete %s", buf.buf);
+ } else if (opt_a) {
+ struct ref_states states;
+ memset(&states, 0, sizeof(states));
+ get_remote_ref_states(argv[0], &states, 1);
+ head_name = xstrdup(states.head_name);
+ free_remote_ref_states(&states);
+ } else
+ head_name = xstrdup(argv[1]);
+
+ if (head_name) {
+ unsigned char sha1[20];
+ strbuf_addf(&buf2, "refs/remotes/%s/%s", argv[0], head_name);
+ /* make sure it's valid */
+ if (!resolve_ref(buf2.buf, sha1, 1, NULL))
+ result |= error("Not a valid ref: %s", buf2.buf);
+ else if (create_symref(buf.buf, buf2.buf, "remote set-head"))
+ result |= error("Could not setup %s", buf.buf);
+ free(head_name);
+ }
+
+ strbuf_release(&buf);
+ strbuf_release(&buf2);
+ return result;
+}
+
static int prune(int argc, const char **argv)
{
int dry_run = 0, result = 0;
@@ -947,6 +997,8 @@ int cmd_remote(int argc, const char **argv, const char *prefix)
result = mv(argc, argv);
else if (!strcmp(argv[0], "rm"))
result = rm(argc, argv);
+ else if (!strcmp(argv[0], "set-head"))
+ result = sethead(argc, argv);
else if (!strcmp(argv[0], "show"))
result = show(argc, argv);
else if (!strcmp(argv[0], "prune"))
diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
index f44f63c..5de1922 100755
--- a/contrib/completion/git-completion.bash
+++ b/contrib/completion/git-completion.bash
@@ -1414,7 +1414,7 @@ _git_config ()
_git_remote ()
{
- local subcommands="add rename rm show prune update"
+ local subcommands="add rename rm show prune update set-head"
local subcommand="$(__git_find_subcommand "$subcommands")"
if [ -z "$subcommand" ]; then
__gitcomp "$subcommands"
--
1.6.2.rc0.209.g7c178
next prev parent reply other threads:[~2009-02-13 8:56 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-13 8:54 [PATCH 0/4] remote HEAD improvements take 2 Jay Soffian
2009-02-13 8:54 ` [PATCH 1/4] builtin-clone: move locate_head() to remote.c so it can be re-used Jay Soffian
2009-02-13 8:54 ` [PATCH 2/4] builtin-remote: move duplicated cleanup code its own function Jay Soffian
2009-02-13 8:54 ` [PATCH 3/4] builtin-remote: teach show to display remote HEAD Jay Soffian
2009-02-13 8:54 ` Jay Soffian [this message]
2009-02-13 10:09 ` [PATCH 4/4] builtin-remote: add set-head verb Junio C Hamano
2009-02-13 10:21 ` Jay Soffian
2009-02-13 11:42 ` [PATCH v2 4/4] builtin-remote: add set-head subcommand Jay Soffian
2009-02-13 10:35 ` [PATCH 4/4] builtin-remote: add set-head verb Junio C Hamano
2009-02-13 10:52 ` Jay Soffian
2009-02-14 0:22 ` Jeff King
2009-02-14 2:00 ` Junio C Hamano
2009-02-14 2:18 ` Jeff King
2009-02-14 2:48 ` Jay Soffian
2009-02-14 2:59 ` Jay Soffian
2009-02-14 3:43 ` Jeff King
2009-02-14 10:30 ` [PATCH] builtin-remote: better handling of multiple remote HEADs Jay Soffian
2009-02-14 17:54 ` Jeff King
2009-02-14 18:35 ` Jay Soffian
2009-02-14 18:54 ` Jeff King
2009-02-14 19:48 ` Junio C Hamano
2009-02-14 20:21 ` Daniel Barkalow
2009-02-14 21:15 ` Jeff King
2009-02-15 6:08 ` Jeff King
2009-02-15 6:10 ` [PATCH 1/5] test scripts: refactor start_httpd helper Jeff King
2009-02-15 6:12 ` [PATCH 2/5] add basic http clone/fetch tests Jeff King
2009-02-15 8:01 ` Junio C Hamano
2009-02-15 6:12 ` [PATCH 3/5] refactor find_refs_by_name to accept const list Jeff King
2009-02-15 6:16 ` [PATCH 4/5] remote: refactor guess_remote_head Jeff King
2009-02-15 6:18 ` [PATCH 5/5] remote: use exact HEAD lookup if it is available Jeff King
2009-02-15 15:22 ` Jay Soffian
2009-02-15 19:58 ` Jeff King
2009-02-15 20:00 ` [PATCH 1/2] transport: cleanup duplicated ref fetching code Jeff King
2009-02-15 20:01 ` [PATCH 2/2] transport: unambiguously determine local HEAD Jeff King
2009-02-15 5:27 ` [PATCH] builtin-remote: better handling of multiple remote HEADs Jeff King
2009-02-15 5:34 ` Jeff King
2009-02-15 14:13 ` Jay Soffian
2009-02-15 15:12 ` Jeff King
2009-02-16 2:21 ` Junio C Hamano
2009-02-16 2:58 ` Jay Soffian
2009-02-13 8:57 ` [PATCH 0/4] remote HEAD improvements take 2 Jay Soffian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1234515275-91263-5-git-send-email-jaysoffian@gmail.com \
--to=jaysoffian@gmail.com \
--cc=barkalow@iabervon.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).