From: Gerfried Fuchs <rhonda@deb.at>
To: git@vger.kernel.org
Cc: Gerfried Fuchs <rhonda@deb.at>
Subject: [PATCH] git-svn: Allow using arguments to the editor.
Date: Wed, 18 Feb 2009 14:47:49 +0100 [thread overview]
Message-ID: <1234964869-11159-1-git-send-email-rhonda@deb.at> (raw)
When setting the EDITOR or VISUAL environment variable, one might want
to hand over arguments (like e.g. for not backgrounding a GUI editor but
waiting for it to finish. This patch enables that posibility, before it
did look for a program with the content of the variable, including the
space as filename part. The change is in sync with regular behavior with
various other tools, git itself included.
Signed-off-by: Gerfried Fuchs <rhonda@deb.at>
---
git-svn.perl | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/git-svn.perl b/git-svn.perl
index 83cb36f..d29664c 100755
--- a/git-svn.perl
+++ b/git-svn.perl
@@ -1137,8 +1137,9 @@ sub get_commit_entry {
if ($_edit || ($type eq 'tree')) {
my $editor = $ENV{VISUAL} || $ENV{EDITOR} || 'vi';
+ my (@editor) = split /\s+/, $editor;
# TODO: strip out spaces, comments, like git-commit.sh
- system($editor, $commit_editmsg);
+ system(@editor, $commit_editmsg);
}
rename $commit_editmsg, $commit_msg or croak $!;
{
--
1.5.6.5
next reply other threads:[~2009-02-18 14:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-18 13:47 Gerfried Fuchs [this message]
2009-02-18 14:15 ` [PATCH] git-svn: Allow using arguments to the editor Thomas Rast
2009-02-18 14:48 ` Gerfried Fuchs
2009-02-18 15:43 ` Thomas Rast
2009-02-19 8:10 ` Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1234964869-11159-1-git-send-email-rhonda@deb.at \
--to=rhonda@deb.at \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).