git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Michael Haggerty <mhagger@alum.mit.edu>
To: git@vger.kernel.org
Cc: gitster@pobox.com, peff@peff.net, Johannes.Schindelin@gmx.de,
	jnareb@gmail.com, Michael Haggerty <mhagger@alum.mit.edu>
Subject: [PATCH v2 0/4] Add more tests of cvsimport
Date: Sat, 21 Feb 2009 14:04:35 +0100	[thread overview]
Message-ID: <1235221480-31473-1-git-send-email-mhagger@alum.mit.edu> (raw)

Thanks for all the feedback.  I think I have incorporated it all:

- Renamed the library from t/t96xx/cvs-lib.sh to t/lib-cvs.sh.

- Added t/t9601/cvsroot/.gitattributes to avoid whitespace warnings.

- Fixed the "cvs co" command for when checking out a branch/tag.

- Implemented a recursive diff in test_cmp_branch_tree rather than
  relying on GNU diff features.  It is only a dozen lines of code, but
  please review this carefully as I'm not such a shell jockey.

  I tried using "git diff" but it didn't seem to work for this
  purpose, even if I deleted the CVS directories manually to avoid the
  need for "-x" functionality:

  - If I used --no-index, it insisted on showing differences within
    the .git directory.

  - It didn't seem to find any differences (even when there were some)
    when I didn't use --no-index.

  - I couldn't see any documentation that the return value is nonzero
    iff differences are found.  In my tests the return value was
    always zero.

  The library can always be changed later to use "git diff", but I
  don't see this as urgent.  It would also have the disadvantage of
  making "git cvsimport" tests fail if there are bugs in "git diff".

I also added another test script, t9602, in the (new) 5th patch in the
series.  It tests "git cvsimport"'s handling of branches and tags.
Only 5/11 of the tests in this script pass.

Cheers,
Michael

             reply	other threads:[~2009-02-21 13:06 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-21 13:04 Michael Haggerty [this message]
2009-02-21 13:04 ` [PATCH v2 1/5] Start a library for cvsimport-related tests Michael Haggerty
2009-02-21 13:04   ` [PATCH v2 2/5] Use CVS's -f option if available (ignore user's ~/.cvsrc file) Michael Haggerty
2009-02-21 13:04     ` [PATCH v2 3/5] Test contents of entire cvsimported "master" tree contents Michael Haggerty
2009-02-21 13:04       ` [PATCH v2 4/5] Add some tests of git-cvsimport's handling of vendor branches Michael Haggerty
2009-02-21 13:04         ` [PATCH v2 5/5] Add a test of "git cvsimport"'s handling of tags and branches Michael Haggerty
2009-02-22 16:49         ` [PATCH v2 4/5] Add some tests of git-cvsimport's handling of vendor branches Junio C Hamano
2009-02-23  5:08           ` [PATCH v3 0/5] Add more tests of cvsimport Michael Haggerty
2009-02-23  5:08             ` [PATCH v3 1/5] Start a library for cvsimport-related tests Michael Haggerty
2009-02-23  5:08               ` [PATCH v3 2/5] Use CVS's -f option if available (ignore user's ~/.cvsrc file) Michael Haggerty
2009-02-23  5:08                 ` [PATCH v3 3/5] Test contents of entire cvsimported "master" tree contents Michael Haggerty
2009-02-23  5:08                   ` [PATCH v3 4/5] Add some tests of git-cvsimport's handling of vendor branches Michael Haggerty
2009-02-23  5:08                     ` [PATCH v3 5/5] Add a test of "git cvsimport"'s handling of tags and branches Michael Haggerty
2009-02-22 16:48 ` [PATCH v2 0/4] Add more tests of cvsimport Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1235221480-31473-1-git-send-email-mhagger@alum.mit.edu \
    --to=mhagger@alum.mit.edu \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=jnareb@gmail.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).