From: Junio C Hamano <gitster@pobox.com>
To: git@vger.kernel.org
Subject: [PATCH 4/4] "git init --remote=host:path"
Date: Sat, 28 Feb 2009 16:03:42 -0800 [thread overview]
Message-ID: <1235865822-14625-4-git-send-email-gitster@pobox.com> (raw)
In-Reply-To: <1235865822-14625-3-git-send-email-gitster@pobox.com>
This implements the requesting side of the pair.
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
builtin-init-db.c | 44 ++++++++++++++++++++++++++++++++++++++++++++
t/t0001-init.sh | 12 ++++++++++++
2 files changed, 56 insertions(+), 0 deletions(-)
diff --git a/builtin-init-db.c b/builtin-init-db.c
index 9628803..18754d7 100644
--- a/builtin-init-db.c
+++ b/builtin-init-db.c
@@ -6,6 +6,7 @@
#include "cache.h"
#include "builtin.h"
#include "exec_cmd.h"
+#include "pkt-line.h"
#ifndef DEFAULT_GIT_TEMPLATE_DIR
#define DEFAULT_GIT_TEMPLATE_DIR "/usr/share/git-core/templates"
@@ -363,6 +364,37 @@ static int guess_repository_type(const char *git_dir)
return 1;
}
+static int remote_init(const char *remote, const char *init_serve,
+ int argc, const char **argv)
+{
+ struct child_process *child;
+ int fd[2], i, len, status;
+ char line[1000];
+
+ if (!init_serve)
+ init_serve = "git init-serve";
+ child = git_connect(fd, remote, init_serve, 0);
+ for (i = 1; i < argc; i++) {
+ const char *arg = argv[i];
+ if (!prefixcmp(arg, "--remote=") ||
+ !prefixcmp(arg, "--exec="))
+ continue;
+ packet_write(fd[1], "arg %s\n", argv[i]);
+ }
+ packet_flush(fd[1]);
+
+ status = 0;
+ len = packet_read_line(fd[0], line, sizeof(line));
+ if (len < 3 ||
+ (memcmp(line, "ok ", 3) && memcmp(line, "ng ", 3)))
+ die("protocol error: %s\n", line);
+
+ if (line[0] != 'o')
+ status = error("%s", line);
+ status |= finish_connect(child);
+ return status;
+}
+
static const char init_db_usage[] =
"git init [-q | --quiet] [--bare] [--template=<template-directory>] [--shared[=<permissions>]]";
@@ -378,6 +410,8 @@ int cmd_init_db(int argc, const char **argv, const char *prefix)
const char *template_dir = NULL;
unsigned int flags = 0;
const char *shared_given = NULL;
+ const char *remote_given = NULL;
+ const char *exec_given = NULL;
int bare_given = 0;
int i;
@@ -394,10 +428,20 @@ int cmd_init_db(int argc, const char **argv, const char *prefix)
shared_given = arg + 9;
else if (!strcmp(arg, "-q") || !strcmp(arg, "--quiet"))
flags |= INIT_DB_QUIET;
+ else if (!prefixcmp(arg, "--remote="))
+ remote_given = arg + 9;
+ else if (!prefixcmp(arg, "--exec="))
+ exec_given = arg + 7;
else
usage(init_db_usage);
}
+ if (remote_given || exec_given) {
+ if (!remote_given)
+ die("--exec= without --remote=?");
+ return remote_init(remote_given, exec_given, argc, argv);
+ }
+
if (bare_given) {
static char git_dir[PATH_MAX+1];
is_bare_repository_cfg = 1;
diff --git a/t/t0001-init.sh b/t/t0001-init.sh
index 5ac0a27..6f47930 100755
--- a/t/t0001-init.sh
+++ b/t/t0001-init.sh
@@ -199,4 +199,16 @@ test_expect_success 'init honors global core.sharedRepository' '
x`git config -f shared-honor-global/.git/config core.sharedRepository`
'
+test_expect_success 'init --remote' '
+ R="$(pwd)/test-of-remote" &&
+ test_must_fail git init --remote="$R" --bare --template=frotz &&
+ git init --remote="$R" --bare &&
+ test -d "$R/objects/pack" &&
+ test_must_fail git init --remote="$R" &&
+ rm -fr "$R" &&
+ test_must_fail git init --remote="$R" --exec="false is not git" &&
+ git init --remote="$R" --exec="$TEST_DIRECTORY/../git-init-serve" &&
+ test -d "$R/.git/objects/pack"
+'
+
test_done
--
1.6.2.rc2.99.g9f3bb
next prev parent reply other threads:[~2009-03-01 0:05 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-01 0:03 [PATCH 1/4] Refactor list of environment variables to be sanitized Junio C Hamano
2009-03-01 0:03 ` [PATCH 2/4] git-init: inject some sanity to the option parser Junio C Hamano
2009-03-01 0:03 ` [PATCH 3/4] Add init-serve, the remote side of "git init --remote=host:path" Junio C Hamano
2009-03-01 0:03 ` Junio C Hamano [this message]
2009-03-01 3:16 ` Jeff King
2009-03-01 5:54 ` Junio C Hamano
2009-03-01 10:00 ` Jeff King
2009-03-01 17:04 ` Shawn O. Pearce
2009-03-03 6:50 ` Subject: [PATCH] Push to create Junio C Hamano
2009-03-03 7:09 ` Jay Soffian
2009-03-03 7:09 ` Jeff King
2009-03-03 7:37 ` Jay Soffian
2009-03-03 7:39 ` Jay Soffian
2009-03-03 7:56 ` Junio C Hamano
2009-03-03 8:02 ` Jay Soffian
2009-03-03 8:04 ` Junio C Hamano
2009-03-03 8:04 ` Junio C Hamano
2009-03-03 8:16 ` Jay Soffian
2009-03-03 8:23 ` Jeff King
2009-03-03 19:57 ` Jay Soffian
2009-03-04 5:42 ` Jeff King
2009-03-04 6:35 ` Junio C Hamano
2009-03-04 13:06 ` Jay Soffian
2009-03-03 7:55 ` Junio C Hamano
2009-03-03 8:06 ` Jeff King
2009-03-03 8:22 ` Junio C Hamano
2009-03-03 8:27 ` Jeff King
2009-03-03 8:30 ` Junio C Hamano
2009-03-03 8:41 ` Jay Soffian
2009-03-03 9:23 ` Theodore Tso
2009-03-03 10:39 ` Johannes Schindelin
2009-03-04 17:58 ` Theodore Tso
2009-03-06 1:37 ` Miles Bader
2009-03-03 18:41 ` Shawn O. Pearce
2009-03-04 8:32 ` [RFC/PATCH 1/2] improve missing repository error message Jeff King
2009-03-04 9:19 ` Matthieu Moy
2009-03-04 10:35 ` Jeff King
2009-03-04 18:57 ` Shawn O. Pearce
2009-03-05 10:36 ` Jeff King
2009-03-04 8:42 ` [RFC/PATCH 2/2] make remote hangup warnings more friendly Jeff King
2009-03-04 19:04 ` Shawn O. Pearce
2009-03-05 10:45 ` Jeff King
2009-03-03 21:08 ` Subject: [PATCH] Push to create Daniel Barkalow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1235865822-14625-4-git-send-email-gitster@pobox.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).