From: Chris Johnsen <chris_johnsen@pobox.com>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
Chris Johnsen <chris_johnsen@pobox.com>
Subject: Re: [PATCH] git-push.txt: describe how to default to pushing only current branch
Date: Sat, 14 Mar 2009 21:49:09 -0500 [thread overview]
Message-ID: <1237085349-14824-1-git-send-email-chris_johnsen@pobox.com> (raw)
In-Reply-To: <20090314205628.GA17445@coredump.intra.peff.net>
On 2009 Mar 14, at 15:56, Jeff King wrote:
> On Sat, Mar 14, 2009 at 04:34:34PM -0400, Jeff King wrote:
> > The question is how it _should_ be rendered. Monospace isn't really
> > useful for terminals. Maybe simply putting quotation marks around it
> > would cover all situations (I'm worried it will look funny for
> > single-word instances).
>
> And here's a patch that does that; skimming through the output it
> doesn't look too bad. What do you guys think?
>
> ---
The presentation seems OK to me. I thought of two issues:
1) literals that contain a double quote
$ git grep '`[^`]*"[^`]`' | cat
config.txt:You can have `[section]` if you have `[section "subsection"]`, but you
There might be a better regexp to find these, I did not think
about it too long. The above "hit" seems like a reasonable
literal string. Maybe it is OK to live with this one
("[section "subsection"]").
2) manpage-1.72.xsl
I have been setting DOCBOOK_XSL_172 to avoid the ".ft" problem
(<http://article.gmane.org/gmane.comp.version-control.git/112943>;
my system is Mac OS X 10.4.11 with MacPorts asciidoc 8.3.1,
xmlto version 0.0.21, and docbook-xsl 1.74.0). Since non-null
DOCBOOK_XSL_172 replaces callouts.xsl with manpage-1.72.xsl, I
added the line to manpage-1.72.xsl.
Here is the patch if it is deemed appropriate (same line Peff
added to callouts.xsl):
-- >8 --
Subject: [PATCH] manpage-1.72.xsl: wrap inline literal text with double quotes
Signed-off-by: Chris Johnsen <chris_johnsen@pobox.com>
---
Documentation/manpage-1.72.xsl | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/Documentation/manpage-1.72.xsl b/Documentation/manpage-1.72.xsl
index 4065a3a..a39fd55 100644
--- a/Documentation/manpage-1.72.xsl
+++ b/Documentation/manpage-1.72.xsl
@@ -18,4 +18,6 @@
<xsl:text>⌂br </xsl:text>
</xsl:template>
+<xsl:template match="literal">"<xsl:apply-templates/>"</xsl:template>
+
</xsl:stylesheet>
--
1.6.2
next prev parent reply other threads:[~2009-03-15 2:51 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-13 7:48 Not pushing all branches? Peter Krefting
2009-03-13 8:12 ` Imran M Yousuf
2009-03-13 9:44 ` Peter Krefting
2009-03-13 10:49 ` Johannes Schindelin
2009-03-13 11:38 ` Finn Arne Gangstad
2009-03-13 8:25 ` John Tapsell
2009-03-13 10:51 ` Johannes Schindelin
2009-03-13 12:37 ` John Tapsell
2009-03-13 13:53 ` Johannes Schindelin
2009-03-13 13:56 ` John Tapsell
2009-03-13 15:48 ` Michael J Gruber
2009-03-13 16:00 ` Johannes Schindelin
2009-03-13 20:02 ` Junio C Hamano
2009-03-14 1:08 ` Miles Bader
2009-03-17 8:24 ` Jeff King
2009-03-13 16:49 ` Jeff King
2009-03-14 1:27 ` [PATCH] git-push.txt: describe how to default to pushing only current branch Chris Johnsen
2009-03-14 19:26 ` Junio C Hamano
2009-03-14 20:34 ` Jeff King
2009-03-14 20:56 ` Jeff King
2009-03-15 2:49 ` Chris Johnsen [this message]
2009-03-15 11:30 ` [PATCH] git-push.txt: describe how to default to pushing only Chris Johnsen
2009-03-17 7:46 ` [PATCH] git-push.txt: describe how to default to pushing only current branch Jeff King
2009-03-14 21:25 ` Junio C Hamano
2009-03-14 21:46 ` Jeff King
2009-03-16 4:51 ` Junio C Hamano
2009-03-15 2:32 ` [PATCH v2] " Chris Johnsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1237085349-14824-1-git-send-email-chris_johnsen@pobox.com \
--to=chris_johnsen@pobox.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).