From: Robin Rosenberg <robin.rosenberg@dewire.com>
To: spearce@sparce.org
Cc: git@vger.kernel.org, Robin Rosenberg <robin.rosenberg@dewire.com>
Subject: [EGIT PATCH 00/10] JGit cleanups
Date: Mon, 16 Mar 2009 21:14:33 +0100 [thread overview]
Message-ID: <1237234483-3405-1-git-send-email-robin.rosenberg@dewire.com> (raw)
Getting annoyed with all the noise I came up with series of cleanups. The
hunk parsing fixes are the one's I'm not really sure about, but my attempts
to find a case that would give an uncontrolled error did not find much
success.
-- robin
Robin Rosenberg (10):
Require javadoc on protected methods in jgit core
Rename the objectsUrl in the nested HttpObjectDB to
Rename variables that hides others with different content in
FetchProcess
Rename a parameter i PackWriter that hides another with the same name
Rename fields to avoid hiding of field names in ReadTreeTest
Rename the gitDir fields to indicate they refer to another dir than
the default
Rename a parameter in PushProcessTest that hides another
Drop unused end parameters in hunk parsing code
Drop unused File arguments in IndexTreeWalker and WorkdirCheckout
Drop an effectively unused parameter in IndexTreeWalker.
.../.settings/org.eclipse.jdt.core.prefs | 7 +-
.../src/org/spearce/jgit/pgm/ReceivePack.java | 10 +-
.../src/org/spearce/jgit/pgm/TextBuiltin.java | 9 +-
.../src/org/spearce/jgit/pgm/UploadPack.java | 10 +-
.../tst/org/spearce/jgit/lib/ReadTreeTest.java | 118 ++++++++++----------
.../spearce/jgit/transport/PushProcessTest.java | 4 +-
.../.settings/org.eclipse.jdt.core.prefs | 5 +-
.../jgit/dircache/DirCacheBuildIterator.java | 2 +-
.../spearce/jgit/dircache/DirCacheIterator.java | 2 +-
.../src/org/spearce/jgit/lib/IndexTreeWalker.java | 12 +-
.../src/org/spearce/jgit/lib/ObjectId.java | 2 +-
.../src/org/spearce/jgit/lib/PackIndex.java | 6 +-
.../src/org/spearce/jgit/lib/PackWriter.java | 8 +-
.../jgit/lib/TreeVisitorWithCurrentDirectory.java | 4 +-
.../src/org/spearce/jgit/lib/WorkDirCheckout.java | 17 ++--
.../org/spearce/jgit/merge/StrategyOneSided.java | 2 +-
.../org/spearce/jgit/patch/CombinedHunkHeader.java | 2 +-
.../src/org/spearce/jgit/patch/FileHeader.java | 18 ++--
.../src/org/spearce/jgit/patch/HunkHeader.java | 6 +-
.../src/org/spearce/jgit/patch/Patch.java | 8 +-
.../org/spearce/jgit/revplot/PlotCommitList.java | 9 ++
.../src/org/spearce/jgit/revplot/PlotWalk.java | 4 +
.../org/spearce/jgit/transport/DaemonService.java | 4 +-
.../org/spearce/jgit/transport/FetchProcess.java | 8 +-
.../org/spearce/jgit/transport/OpenSshConfig.java | 2 +-
.../spearce/jgit/transport/OperationResult.java | 10 +-
.../spearce/jgit/transport/PackedObjectInfo.java | 2 +-
.../src/org/spearce/jgit/transport/PushResult.java | 2 +-
.../spearce/jgit/transport/RemoteRefUpdate.java | 6 +-
.../org/spearce/jgit/transport/TransportHttp.java | 14 +-
.../spearce/jgit/treewalk/WorkingTreeIterator.java | 7 +
31 files changed, 173 insertions(+), 147 deletions(-)
next reply other threads:[~2009-03-16 20:16 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-16 20:14 Robin Rosenberg [this message]
2009-03-16 20:14 ` [EGIT PATCH 01/10] Require javadoc on protected methods in jgit core Robin Rosenberg
2009-03-16 20:14 ` [EGIT PATCH 02/10] Rename the objectsUrl in the nested HttpObjectDB to Robin Rosenberg
2009-03-16 20:14 ` [EGIT PATCH 03/10] Rename variables that hides others with different content in FetchProcess Robin Rosenberg
2009-03-16 20:14 ` [EGIT PATCH 04/10] Rename a parameter i PackWriter that hides another with the same name Robin Rosenberg
2009-03-16 20:14 ` [EGIT PATCH 05/10] Rename fields to avoid hiding of field names in ReadTreeTest Robin Rosenberg
2009-03-16 20:14 ` [EGIT PATCH 06/10] Rename the gitDir fields to indicate they refer to another dir than the default Robin Rosenberg
2009-03-16 20:14 ` [EGIT PATCH 07/10] Rename a parameter in PushProcessTest that hides another Robin Rosenberg
2009-03-16 20:14 ` [EGIT PATCH 08/10] Drop unused end parameters in hunk parsing code Robin Rosenberg
2009-03-16 20:14 ` [EGIT PATCH 09/10] Drop unused File arguments in IndexTreeWalker and WorkdirCheckout Robin Rosenberg
2009-03-16 20:14 ` [EGIT PATCH 10/10] Drop an effectively unused parameter in IndexTreeWalker Robin Rosenberg
2009-03-16 20:39 ` [EGIT PATCH 08/10] Drop unused end parameters in hunk parsing code Shawn O. Pearce
2009-03-16 20:25 ` [EGIT PATCH 02/10] Rename the objectsUrl in the nested HttpObjectDB to Shawn O. Pearce
2009-03-16 21:25 ` Robin Rosenberg
2009-03-16 21:28 ` Shawn O. Pearce
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1237234483-3405-1-git-send-email-robin.rosenberg@dewire.com \
--to=robin.rosenberg@dewire.com \
--cc=git@vger.kernel.org \
--cc=spearce@sparce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).