From: Robin Rosenberg <robin.rosenberg@dewire.com>
To: spearce@spearce.org
Cc: git@vger.kernel.org, Robin Rosenberg <robin.rosenberg@dewire.com>
Subject: [EGIT PATCH 1/4] Add actual test for success to ConnectOperationTest
Date: Wed, 8 Apr 2009 17:51:28 +0200 [thread overview]
Message-ID: <1239205891-28236-1-git-send-email-robin.rosenberg@dewire.com> (raw)
Also remove a few obsolete lines (irrelevant asserts)
Signed-off-by: Robin Rosenberg <robin.rosenberg@dewire.com>
---
.../op/T0001_ConnectProviderOperationTest.java | 16 +++-------------
1 files changed, 3 insertions(+), 13 deletions(-)
diff --git a/org.spearce.egit.core.test/src/org/spearce/egit/core/op/T0001_ConnectProviderOperationTest.java b/org.spearce.egit.core.test/src/org/spearce/egit/core/op/T0001_ConnectProviderOperationTest.java
index 092c048..1d332a3 100644
--- a/org.spearce.egit.core.test/src/org/spearce/egit/core/op/T0001_ConnectProviderOperationTest.java
+++ b/org.spearce.egit.core.test/src/org/spearce/egit/core/op/T0001_ConnectProviderOperationTest.java
@@ -89,19 +89,6 @@ public void testNewUnsharedFile() throws CoreException, IOException,
lck.setNewObjectId(id);
assertEquals(RefUpdate.Result.NEW, lck.forceUpdate());
- // helper asserts, this is not what we are really testing
- assertTrue("blob missing", new File(gitDir,
- "objects/2e/2439c32d01f0ef39644d561945e8f4b2239489").exists());
-
- assertTrue("tree missing", new File(gitDir,
- "objects/87/a105cc4bc0a79885d07ec560c3eee49438acf0").exists());
- assertTrue("tree missing", new File(gitDir,
- "objects/08/ccc3d91a14d337a45f355d3d63bd97fd5e4db9").exists());
- assertTrue("tree missing", new File(gitDir,
- "objects/9d/aeec817090098f05eeca858e3a552d78b0a346").exists());
- assertTrue("commit missing", new File(gitDir,
- "objects/09/6f1a84091b90b6d9fb12f95848da69496305c1").exists());
-
ConnectProviderOperation operation = new ConnectProviderOperation(
project.getProject(), null);
operation.run(null);
@@ -125,5 +112,8 @@ protected IStatus run(IProgressMonitor monitor) {
Thread.sleep(1000);
}
System.out.println("DONE");
+
+ assertNotNull(RepositoryProvider.getProvider(project.getProject()));
+
}
}
--
1.6.2.2.446.gfbdc0
next reply other threads:[~2009-04-08 15:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-08 15:51 Robin Rosenberg [this message]
2009-04-08 15:51 ` [EGIT PATCH 2/4] Add a method to RepositoryMapping to get the directory for not-yet-mapped projects Robin Rosenberg
2009-04-08 15:51 ` [EGIT PATCH 3/4] Use explicit bundle name in UIText to aid IDE integration Robin Rosenberg
2009-04-08 15:51 ` [EGIT PATCH 4/4] Multi-project connect to Git provider Robin Rosenberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1239205891-28236-1-git-send-email-robin.rosenberg@dewire.com \
--to=robin.rosenberg@dewire.com \
--cc=git@vger.kernel.org \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).