From: Robin Rosenberg <robin.rosenberg@dewire.com>
To: spearce@spearce.org
Cc: git@vger.kernel.org, Robin Rosenberg <robin.rosenberg@dewire.com>
Subject: [EGIT PATCH] Some logging of errors GUI's.
Date: Tue, 14 Apr 2009 01:26:01 +0200 [thread overview]
Message-ID: <1239665161-24033-1-git-send-email-robin.rosenberg@dewire.com> (raw)
Though, hopefully rare, we might want to have errors logged.
Signed-off-by: Robin Rosenberg <robin.rosenberg@dewire.com>
---
.../GitCompareFileRevisionEditorInput.java | 2 ++
.../egit/ui/internal/dialogs/CommitDialog.java | 3 +++
2 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/GitCompareFileRevisionEditorInput.java b/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/GitCompareFileRevisionEditorInput.java
index 49d4a42..88c867d 100644
--- a/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/GitCompareFileRevisionEditorInput.java
+++ b/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/GitCompareFileRevisionEditorInput.java
@@ -35,6 +35,7 @@
import org.eclipse.team.internal.ui.synchronize.LocalResourceTypedElement;
import org.eclipse.team.ui.synchronize.SaveableCompareEditorInput;
import org.eclipse.ui.IWorkbenchPage;
+import org.spearce.egit.core.Activator;
/**
* The input provider for the compare editor when working on resources
@@ -327,6 +328,7 @@ private String getContentIdentifier(ITypedElement element){
return TeamUIMessages.CompareFileRevisionEditorInput_1;
}
} catch (CoreException e) {
+ Activator.logError("Problem getting content identifier", e);
}
} else {
return fileRevisionElement.getContentIdentifier();
diff --git a/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/dialogs/CommitDialog.java b/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/dialogs/CommitDialog.java
index e6bd02d..ce7196f 100644
--- a/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/dialogs/CommitDialog.java
+++ b/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/dialogs/CommitDialog.java
@@ -59,6 +59,7 @@
import org.eclipse.team.core.history.IFileRevision;
import org.eclipse.team.internal.ui.history.FileRevisionTypedElement;
import org.eclipse.ui.model.WorkbenchLabelProvider;
+import org.spearce.egit.core.Activator;
import org.spearce.egit.core.GitProvider;
import org.spearce.egit.core.internal.storage.GitFileHistoryProvider;
import org.spearce.egit.core.project.RepositoryMapping;
@@ -434,6 +435,8 @@ private static String getFileStatus(IFile file) {
}
} catch (Exception e) {
+ Activator.logError("Problem in finding file status", e);
+ prefix = e.getMessage();
}
return prefix;
--
1.6.2.2.446.gfbdc0
reply other threads:[~2009-04-13 23:27 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1239665161-24033-1-git-send-email-robin.rosenberg@dewire.com \
--to=robin.rosenberg@dewire.com \
--cc=git@vger.kernel.org \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).