From: Frank Lichtenheld <frank@lichtenheld.de>
To: gitster@pobox.com
Cc: git@vger.kernel.org, Frank Lichtenheld <flichtenheld@astaro.com>
Subject: [PATCH] init: Do not segfault on big GIT_TEMPLATE_DIR environment variable
Date: Sat, 18 Apr 2009 16:14:02 +0200 [thread overview]
Message-ID: <1240064042-22539-1-git-send-email-frank@lichtenheld.de> (raw)
From: Frank Lichtenheld <flichtenheld@astaro.com>
Signed-off-by: Frank Lichtenheld <flichtenheld@astaro.com>
---
builtin-init-db.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/builtin-init-db.c b/builtin-init-db.c
index 4e02b33..d1fa12a 100644
--- a/builtin-init-db.c
+++ b/builtin-init-db.c
@@ -122,8 +122,10 @@ static void copy_templates(const char *template_dir)
template_dir = system_path(DEFAULT_GIT_TEMPLATE_DIR);
if (!template_dir[0])
return;
+ template_len = strlen(template_dir);
+ if (PATH_MAX <= (template_len+strlen("/config")))
+ die("insanely long template path %s", template_dir);
strcpy(template_path, template_dir);
- template_len = strlen(template_path);
if (template_path[template_len-1] != '/') {
template_path[template_len++] = '/';
template_path[template_len] = 0;
--
1.6.2.1
reply other threads:[~2009-04-18 14:31 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1240064042-22539-1-git-send-email-frank@lichtenheld.de \
--to=frank@lichtenheld.de \
--cc=flichtenheld@astaro.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).