From: Frank Terbeck <ft@bewatermyfriend.org>
To: git@vger.kernel.org
Cc: Frank Terbeck <ft@bewatermyfriend.org>
Subject: [PATCH 0/6] more automation for cover letter generation
Date: Sat, 18 Apr 2009 18:16:15 +0200 [thread overview]
Message-ID: <1240071381-25165-1-git-send-email-ft@bewatermyfriend.org> (raw)
I like cover letters, in fact I like them enough to always want
--cover-letter to format-patch. The problem with that are patch "series"
that are only one patch long, where a cover letter would feel silly.
For now, I solved that by using a shell function that wrapped around
format-patch and did the trick for me.
With this series, format-patch can do it and do it better than my
wrapper could.
The following setup would suit me pretty well:
[format]
coverletter = true
coveronepatch = false
overwritecoverletter = false
The series is based on master and doesn't seem to break anything
within the test suite. It could maybe use own tests, but I must admit
that I didn't look too closely at how git's test suite works and where
to put in tests for this.
Finally, this series does not change anything about format-patch's
default behaviour.
Regards, Frank
Frank Terbeck (6):
format-patch: add cover{letter,onepatch} options
The above makes it possible to *always* create cover letters
without requesting it via --cover-letter. You can also suppress
cover letters for patch series, that are just one patch long,
where you'd probably put anything you have to say in addition
between '---' and the diffstat.
Add documentation for format-patch's --cover-one-patch
Document format.coverletter and format.coveronepatch
format-patch: introduce overwritecoverletter option
When you're always generating cover letters, it can be a good idea
to not overwrite an existing cover letter, especially if you're
just refreshing your patch series, or added more commits to it -
were comments you may have made in an existing cover letter might
be valuable for the new patch series as well. Therefore setting
overwritecoverletter to false protects you from overwriting an
existing cover letter.
I had hoped that this change would be possible without changes in so
many places, but I didn't see a straight forward one.
Add documentation for --cover-overwrite
Document format.overwritecoverletter
Documentation/config.txt | 15 +++++++++++++
Documentation/git-format-patch.txt | 11 +++++++++
builtin-log.c | 40 +++++++++++++++++++++++++++++++----
log-tree.c | 9 +++++--
log-tree.h | 4 +-
5 files changed, 69 insertions(+), 10 deletions(-)
next reply other threads:[~2009-04-18 16:18 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-18 16:16 Frank Terbeck [this message]
2009-04-18 16:16 ` [PATCH 1/6] format-patch: add cover{letter,onepatch} options Frank Terbeck
2009-04-18 16:16 ` [PATCH 2/6] Add documentation for format-patch's --cover-one-patch Frank Terbeck
2009-04-18 16:16 ` [PATCH 3/6] Document format.coverletter and format.coveronepatch Frank Terbeck
2009-04-18 16:16 ` [PATCH 4/6] format-patch: introduce overwritecoverletter option Frank Terbeck
2009-04-18 16:16 ` [PATCH 5/6] Add documentation for --cover-overwrite Frank Terbeck
2009-04-18 16:16 ` [PATCH 6/6] Document format.overwritecoverletter Frank Terbeck
2009-04-18 18:31 ` [PATCH 0/6] more automation for cover letter generation Junio C Hamano
2009-05-04 9:58 ` [PATCH v2 0/4] " Frank Terbeck
2009-05-04 9:58 ` [PATCH v2 1/4] Add format.coverletter option Frank Terbeck
2009-05-04 9:59 ` [PATCH v2 2/4] Add format.coverauto boolean Frank Terbeck
2009-05-04 18:39 ` Stephen Boyd
2009-05-04 21:41 ` Frank Terbeck
2009-05-04 23:20 ` Junio C Hamano
2009-05-05 8:49 ` Frank Terbeck
2009-05-05 10:41 ` Junio C Hamano
2009-05-05 13:29 ` Frank Terbeck
2009-05-05 15:23 ` Frank Terbeck
2009-05-04 9:59 ` [PATCH v2 3/4] Add tests for coverauto, coverletter and --cover-letter Frank Terbeck
2009-05-04 9:59 ` [PATCH v2 4/4] Documentation for format.coverletter " Frank Terbeck
2009-04-21 3:32 ` [PATCH 0/6] more automation for cover letter generation Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1240071381-25165-1-git-send-email-ft@bewatermyfriend.org \
--to=ft@bewatermyfriend.org \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).