From: Frank Terbeck <ft@bewatermyfriend.org>
To: git@vger.kernel.org
Cc: Frank Terbeck <ft@bewatermyfriend.org>
Subject: [PATCH 1/6] format-patch: add cover{letter,onepatch} options
Date: Sat, 18 Apr 2009 18:16:16 +0200 [thread overview]
Message-ID: <1240071381-25165-2-git-send-email-ft@bewatermyfriend.org> (raw)
In-Reply-To: <1240071381-25165-1-git-send-email-ft@bewatermyfriend.org>
When using --cover-letter, a cover letter is created even if the patch
series is only one patch long. By setting format.coveronepatch to 'false', this
is prevented. To temporarily force creating cover letter even for
one-patch "series", the --cover-one-patch option may be used.
To always create cover letters, the format.coverletter option may be set
to 'true'.
A possible setup to create cover letters for every created patch series,
that is longer than one patch, would be:
[format]
coverletter = true
coveronepatch = false
git-format-patch's default behaviour is not altered by this patch.
Signed-off-by: Frank Terbeck <ft@bewatermyfriend.org>
---
builtin-log.c | 16 +++++++++++++++-
1 files changed, 15 insertions(+), 1 deletions(-)
diff --git a/builtin-log.c b/builtin-log.c
index 5eaec5d..82d8724 100644
--- a/builtin-log.c
+++ b/builtin-log.c
@@ -436,6 +436,9 @@ static char **extra_cc;
static int extra_cc_nr;
static int extra_cc_alloc;
+static int cover_letter = 0;
+static int cover_one_patch = 1;
+
static void add_header(const char *value)
{
int len = strlen(value);
@@ -512,6 +515,14 @@ static int git_format_config(const char *var, const char *value, void *cb)
do_signoff = git_config_bool(var, value);
return 0;
}
+ if (!strcmp(var, "format.coverletter")) {
+ cover_letter = git_config_bool(var, value);
+ return 0;
+ }
+ if (!strcmp(var, "format.coveronepatch")) {
+ cover_one_patch = git_config_bool(var, value);
+ return 0;
+ }
return git_log_config(var, value, cb);
}
@@ -752,7 +763,6 @@ int cmd_format_patch(int argc, const char **argv, const char *prefix)
int numbered_files = 0; /* _just_ numbers */
int subject_prefix = 0;
int ignore_if_in_upstream = 0;
- int cover_letter = 0;
int boundary_count = 0;
int no_binary_diff = 0;
struct commit *origin = NULL, *head = NULL;
@@ -868,6 +878,8 @@ int cmd_format_patch(int argc, const char **argv, const char *prefix)
fmt_patch_suffix = argv[i] + 9;
else if (!strcmp(argv[i], "--cover-letter"))
cover_letter = 1;
+ else if (!strcmp(argv[i], "--cover-one-patch"))
+ cover_one_patch = 1;
else if (!strcmp(argv[i], "--no-binary"))
no_binary_diff = 1;
else if (!prefixcmp(argv[i], "--add-header="))
@@ -1010,6 +1022,8 @@ int cmd_format_patch(int argc, const char **argv, const char *prefix)
list[nr - 1] = commit;
}
total = nr;
+ if (!cover_one_patch && total == 1)
+ cover_letter = 0;
if (!keep_subject && auto_number && total > 1)
numbered = 1;
if (numbered)
--
1.6.2.2.446.gfbdc0
next prev parent reply other threads:[~2009-04-18 16:18 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-18 16:16 [PATCH 0/6] more automation for cover letter generation Frank Terbeck
2009-04-18 16:16 ` Frank Terbeck [this message]
2009-04-18 16:16 ` [PATCH 2/6] Add documentation for format-patch's --cover-one-patch Frank Terbeck
2009-04-18 16:16 ` [PATCH 3/6] Document format.coverletter and format.coveronepatch Frank Terbeck
2009-04-18 16:16 ` [PATCH 4/6] format-patch: introduce overwritecoverletter option Frank Terbeck
2009-04-18 16:16 ` [PATCH 5/6] Add documentation for --cover-overwrite Frank Terbeck
2009-04-18 16:16 ` [PATCH 6/6] Document format.overwritecoverletter Frank Terbeck
2009-04-18 18:31 ` [PATCH 0/6] more automation for cover letter generation Junio C Hamano
2009-05-04 9:58 ` [PATCH v2 0/4] " Frank Terbeck
2009-05-04 9:58 ` [PATCH v2 1/4] Add format.coverletter option Frank Terbeck
2009-05-04 9:59 ` [PATCH v2 2/4] Add format.coverauto boolean Frank Terbeck
2009-05-04 18:39 ` Stephen Boyd
2009-05-04 21:41 ` Frank Terbeck
2009-05-04 23:20 ` Junio C Hamano
2009-05-05 8:49 ` Frank Terbeck
2009-05-05 10:41 ` Junio C Hamano
2009-05-05 13:29 ` Frank Terbeck
2009-05-05 15:23 ` Frank Terbeck
2009-05-04 9:59 ` [PATCH v2 3/4] Add tests for coverauto, coverletter and --cover-letter Frank Terbeck
2009-05-04 9:59 ` [PATCH v2 4/4] Documentation for format.coverletter " Frank Terbeck
2009-04-21 3:32 ` [PATCH 0/6] more automation for cover letter generation Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1240071381-25165-2-git-send-email-ft@bewatermyfriend.org \
--to=ft@bewatermyfriend.org \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).