From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthieu Moy Subject: [PATCH] BUG: git push on an empty clone segfaults. Date: Mon, 20 Apr 2009 11:48:50 +0200 Message-ID: <1240220930-24679-1-git-send-email-Matthieu.Moy@imag.fr> Cc: Matthieu Moy To: gitster@pobox.com, git@vger.kernel.org X-From: git-owner@vger.kernel.org Mon Apr 20 11:55:32 2009 Return-path: Envelope-to: gcvg-git-2@gmane.org Received: from vger.kernel.org ([209.132.176.167]) by lo.gmane.org with esmtp (Exim 4.50) id 1LvqDq-0006YH-09 for gcvg-git-2@gmane.org; Mon, 20 Apr 2009 11:55:30 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754026AbZDTJx4 (ORCPT ); Mon, 20 Apr 2009 05:53:56 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753750AbZDTJx4 (ORCPT ); Mon, 20 Apr 2009 05:53:56 -0400 Received: from imag.imag.fr ([129.88.30.1]:64405 "EHLO imag.imag.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753179AbZDTJxz (ORCPT ); Mon, 20 Apr 2009 05:53:55 -0400 Received: from mail-veri.imag.fr (mail-veri.imag.fr [129.88.43.52]) by imag.imag.fr (8.13.8/8.13.8) with ESMTP id n3K9nfk8010100 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NO); Mon, 20 Apr 2009 11:49:41 +0200 (CEST) Received: from bauges.imag.fr ([129.88.43.5]) by mail-veri.imag.fr with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA:32) (Exim 4.50) id 1Lvq7Q-0006ZK-7g; Mon, 20 Apr 2009 11:48:52 +0200 Received: from moy by bauges.imag.fr with local (Exim 4.63) (envelope-from ) id 1Lvq7Q-0006Qf-56; Mon, 20 Apr 2009 11:48:52 +0200 X-Mailer: git-send-email 1.6.2.2.449.g92961.dirty X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-3.0 (imag.imag.fr [129.88.30.1]); Mon, 20 Apr 2009 11:49:42 +0200 (CEST) X-IMAG-MailScanner-Information: Please contact MI2S MIM for more information X-IMAG-MailScanner: Found to be clean X-IMAG-MailScanner-SpamCheck: X-IMAG-MailScanner-From: moy@imag.fr Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: Ideally, "git push" from an empty repository to another empty one should be a no-op, or perhaps should error out cleanly. Currently, it just segfaults. Signed-off-by: Matthieu Moy --- t/t5701-clone-local.sh | 10 ++++++++++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/t/t5701-clone-local.sh b/t/t5701-clone-local.sh index 3559d17..7c6ef4c 100755 --- a/t/t5701-clone-local.sh +++ b/t/t5701-clone-local.sh @@ -132,4 +132,14 @@ test_expect_success 'clone empty repository' ' test $actual = $expected) ' +test_expect_failure 'clone empty repository, and then push should not segfault.' ' + cd "$D" && + rm -fr empty/ empty-clone/ && + mkdir empty && + (cd empty && git init) && + git clone empty empty-clone && + cd empty-clone && + test_must_fail git push +' + test_done -- 1.6.2.2.449.g92961.dirty