* [PATCH] bisect-helper: fix grammatical typo in exit_if_skipped_commits()
@ 2009-04-21 6:31 Stephen Boyd
2009-04-22 5:01 ` Christian Couder
0 siblings, 1 reply; 2+ messages in thread
From: Stephen Boyd @ 2009-04-21 6:31 UTC (permalink / raw)
To: Junio C Hamano; +Cc: git, Christian Couder
Signed-off-by: Stephen Boyd <bebarino@gmail.com>
---
Christian Couder wrote:
> Le lundi 20 avril 2009, Stephen Boyd a écrit :
>> Christian Couder wrote:
>>> + printf("There are only 'skip'ped commit left to test.\n"
>>> + "The first bad commit could be any of:\n")
>> Should this be "There are only 'skip'ped commits left to test"?
>
> Yes, but the same message was printed previously, so it is a slightly
> incompatible change and I think it should go into another patch. Would you
> care to send such a patch?
>
> Thanks,
> Christian.
This is against pu.
bisect.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/bisect.c b/bisect.c
index f6e1378..5902e83 100644
--- a/bisect.c
+++ b/bisect.c
@@ -575,7 +575,7 @@ static void exit_if_skipped_commits(struct commit_list *tried,
if (!tried)
return;
- printf("There are only 'skip'ped commit left to test.\n"
+ printf("There are only 'skip'ped commits left to test.\n"
"The first bad commit could be any of:\n");
print_commit_list(tried, "%s\n", "%s\n");
if (bad)
--
1.6.2.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] bisect-helper: fix grammatical typo in exit_if_skipped_commits()
2009-04-21 6:31 [PATCH] bisect-helper: fix grammatical typo in exit_if_skipped_commits() Stephen Boyd
@ 2009-04-22 5:01 ` Christian Couder
0 siblings, 0 replies; 2+ messages in thread
From: Christian Couder @ 2009-04-22 5:01 UTC (permalink / raw)
To: Stephen Boyd; +Cc: Junio C Hamano, git
Le mardi 21 avril 2009, Stephen Boyd a écrit :
> This is against pu.
>
> bisect.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/bisect.c b/bisect.c
> index f6e1378..5902e83 100644
> --- a/bisect.c
> +++ b/bisect.c
> @@ -575,7 +575,7 @@ static void exit_if_skipped_commits(struct
> commit_list *tried, if (!tried)
> return;
>
> - printf("There are only 'skip'ped commit left to test.\n"
> + printf("There are only 'skip'ped commits left to test.\n"
> "The first bad commit could be any of:\n");
> print_commit_list(tried, "%s\n", "%s\n");
> if (bad)
Acked-by: Christian Couder <chriscool@tuxfamily.org>
Thanks,
Christian.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-04-22 5:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-04-21 6:31 [PATCH] bisect-helper: fix grammatical typo in exit_if_skipped_commits() Stephen Boyd
2009-04-22 5:01 ` Christian Couder
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).