From: "Shawn O. Pearce" <spearce@spearce.org>
To: Robin Rosenberg <robin.rosenberg@dewire.com>
Cc: git@vger.kernel.org
Subject: [JGIT PATCH 06/11] Use getCachedBytes in IndexPack to avoid an unnecessary copy
Date: Wed, 29 Apr 2009 11:54:43 -0700 [thread overview]
Message-ID: <1241031288-23437-7-git-send-email-spearce@spearce.org> (raw)
In-Reply-To: <1241031288-23437-6-git-send-email-spearce@spearce.org>
This is deep within the library code, where we know we won't overwrite
the cached buffer for an object. Using getCachedBytes saves a full
array copy while fixing a thin pack and appending whole objects. The
extra copy isn't so much an issue of CPU time as it is about creating
unnecessary temporary garbage for the GC to clean up.
Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
---
Unchanged.
.../src/org/spearce/jgit/transport/IndexPack.java | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/org.spearce.jgit/src/org/spearce/jgit/transport/IndexPack.java b/org.spearce.jgit/src/org/spearce/jgit/transport/IndexPack.java
index eecad9c..eeeae16 100644
--- a/org.spearce.jgit/src/org/spearce/jgit/transport/IndexPack.java
+++ b/org.spearce.jgit/src/org/spearce/jgit/transport/IndexPack.java
@@ -500,7 +500,7 @@ private void fixThinPack(final ProgressMonitor progress) throws IOException {
missing.add(baseId);
continue;
}
- final byte[] data = ldr.getBytes();
+ final byte[] data = ldr.getCachedBytes();
final int typeCode = ldr.getType();
final PackedObjectInfo oe;
--
1.6.3.rc3.199.g24398
next prev parent reply other threads:[~2009-04-29 18:56 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-29 18:54 [JGIT PATCH v2 00/11] WindowCache rewrite... with tests Shawn O. Pearce
2009-04-29 18:54 ` [JGIT PATCH 01/11] Fix more computation of integer average overflows Shawn O. Pearce
2009-04-29 18:54 ` [JGIT PATCH 02/11] Fix performance problem recently introduced to DeltaPackedObjectLoader Shawn O. Pearce
2009-04-29 18:54 ` [JGIT PATCH 03/11] Replace inefficient new String(String) constructor to silence FindBugs Shawn O. Pearce
2009-04-29 18:54 ` [JGIT PATCH 04/11] Replace inefficient new Long(long) " Shawn O. Pearce
2009-04-29 18:54 ` [JGIT PATCH 05/11] Change IndexPack to use ObjectIdSubclassMap instead of ObjectIdMap Shawn O. Pearce
2009-04-29 18:54 ` Shawn O. Pearce [this message]
2009-04-29 18:54 ` [JGIT PATCH 07/11] Remove ObjectIdMap from the JGit library Shawn O. Pearce
2009-04-29 18:54 ` [JGIT PATCH 08/11] Don't use ByteWindows when checking pack file headers/footers Shawn O. Pearce
2009-04-29 18:54 ` [JGIT PATCH v2 09/11] Rewrite WindowCache to be easier to follow and maintain Shawn O. Pearce
2009-04-29 18:54 ` [JGIT PATCH 10/11] Add tests for WindowCache.reconfigure cases Shawn O. Pearce
2009-04-29 18:54 ` [JGIT PATCH 11/11] Add tests to increase coverage of WindowCache Shawn O. Pearce
2009-04-29 23:46 ` [JGIT PATCH v2 00/11] WindowCache rewrite... with tests Robin Rosenberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1241031288-23437-7-git-send-email-spearce@spearce.org \
--to=spearce@spearce.org \
--cc=git@vger.kernel.org \
--cc=robin.rosenberg@dewire.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).