git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Shawn O. Pearce" <spearce@spearce.org>
To: Robin Rosenberg <robin.rosenberg@dewire.com>,
	Matthias Sohn <matthias.sohn@sap.com>
Cc: git@vger.kernel.org
Subject: [JGIT PATCH 7/7] FindBugs: Disable clone() idiom tests
Date: Mon,  4 May 2009 16:30:48 -0700	[thread overview]
Message-ID: <1241479848-20687-7-git-send-email-spearce@spearce.org> (raw)
In-Reply-To: <1241479848-20687-6-git-send-email-spearce@spearce.org>

We tend not to implement Cloneable, but instead define our own
form of clone() on objects that we want to permit making clones
of.  This is because Cloneable is a rather poor interface in
the JVM with its implicit field copying, but the method name
is the right name for us.

Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
---
 org.spearce.jgit/.fbprefs |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/org.spearce.jgit/.fbprefs b/org.spearce.jgit/.fbprefs
index d6f94c3..81a0767 100644
--- a/org.spearce.jgit/.fbprefs
+++ b/org.spearce.jgit/.fbprefs
@@ -1,5 +1,5 @@
 #FindBugs User Preferences
-#Mon May 04 20:17:32 CEST 2009
+#Mon May 04 16:24:13 PDT 2009
 detectorAppendingToAnObjectOutputStream=AppendingToAnObjectOutputStream|true
 detectorBadAppletConstructor=BadAppletConstructor|false
 detectorBadResultSetAccess=BadResultSetAccess|true
@@ -10,7 +10,7 @@ detectorBooleanReturnNull=BooleanReturnNull|true
 detectorCallToUnsupportedMethod=CallToUnsupportedMethod|true
 detectorCheckImmutableAnnotation=CheckImmutableAnnotation|true
 detectorCheckTypeQualifiers=CheckTypeQualifiers|true
-detectorCloneIdiom=CloneIdiom|true
+detectorCloneIdiom=CloneIdiom|false
 detectorComparatorIdiom=ComparatorIdiom|true
 detectorConfusedInheritance=ConfusedInheritance|true
 detectorConfusionBetweenInheritedAndOuterMethod=ConfusionBetweenInheritedAndOuterMethod|true
-- 
1.6.3.rc4.206.g03e16

  reply	other threads:[~2009-05-04 23:31 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-04 23:30 [JGIT PATCH 1/7] Fix FindBugs exclude filter to work on UNIX platforms Shawn O. Pearce
2009-05-04 23:30 ` [JGIT PATCH 2/7] Silence FindBugs "dubious use of GC" in PackFile.mmap Shawn O. Pearce
2009-05-04 23:30   ` [JGIT PATCH 3/7] Fix FindBugs String == is bad form Shawn O. Pearce
2009-05-04 23:30     ` [JGIT PATCH 4/7] Fix FindBugs load known null value Shawn O. Pearce
2009-05-04 23:30       ` [JGIT PATCH 5/7] FindBugs: Fix use of byte[].toString() in error messages Shawn O. Pearce
2009-05-04 23:30         ` [JGIT PATCH 6/7] Make TransportLocal.StreamRewritingThread static Shawn O. Pearce
2009-05-04 23:30           ` Shawn O. Pearce [this message]
2009-05-06 11:18 ` [JGIT PATCH 1/7] Fix FindBugs exclude filter to work on UNIX platforms Sohn, Matthias

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1241479848-20687-7-git-send-email-spearce@spearce.org \
    --to=spearce@spearce.org \
    --cc=git@vger.kernel.org \
    --cc=matthias.sohn@sap.com \
    --cc=robin.rosenberg@dewire.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).