From: "Robin H\. Johnson" <robbat2@gentoo.org>
To: git@vger.kernel.org
Cc: "Robin H\. Johnson" <robbat2@gentoo.org>
Subject: [PATCH] Fix sloppy Getopt::Long.
Date: Tue, 5 May 2009 11:16:14 -0700 [thread overview]
Message-ID: <1241547374-6737-1-git-send-email-robbat2@gentoo.org> (raw)
Getopt-Long v2.38 is much stricter about sloppy getopt usage. The
trailing pipe causes git-svn testcases to fail for all of the --stdin
argument calls.
Signed-off-by: Robin H. Johnson <robbat2@gentoo.org>
===
Should be applied to both the stable 1.6.2.x tree and the new 1.6.3
tree.
---
git-svn.perl | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/git-svn.perl b/git-svn.perl
index c5965c9..ef1d30d 100755
--- a/git-svn.perl
+++ b/git-svn.perl
@@ -147,7 +147,7 @@ my %cmd = (
'dry-run|n' => \$_dry_run } ],
'set-tree' => [ \&cmd_set_tree,
"Set an SVN repository to a git tree-ish",
- { 'stdin|' => \$_stdin, %cmt_opts, %fc_opts, } ],
+ { 'stdin' => \$_stdin, %cmt_opts, %fc_opts, } ],
'create-ignore' => [ \&cmd_create_ignore,
'Create a .gitignore per svn:ignore',
{ 'revision|r=i' => \$_revision
--
1.6.2.3
next reply other threads:[~2009-05-05 18:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-05 18:16 Robin H. Johnson [this message]
2009-05-05 19:37 ` [PATCH] Fix sloppy Getopt::Long Junio C Hamano
2009-05-05 20:21 ` Robin H. Johnson
[not found] ` <7vljpazuyg.fsf@alter.siamese.dyndns.org>
[not found] ` <20090506064949.GB29479@dcvr.yhbt.net>
2009-05-06 16:13 ` Robin H. Johnson
2009-05-06 17:24 ` Junio C Hamano
2009-05-08 18:28 ` Robin H. Johnson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1241547374-6737-1-git-send-email-robbat2@gentoo.org \
--to=robbat2@gentoo.org \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).