From: "Shawn O. Pearce" <spearce@spearce.org>
To: Robin Rosenberg <robin.rosenberg@dewire.com>
Cc: git@vger.kernel.org
Subject: [JGIT PATCH 0/7] Misc. transport cleanup
Date: Thu, 4 Jun 2009 14:43:56 -0700 [thread overview]
Message-ID: <1244151843-26954-1-git-send-email-spearce@spearce.org> (raw)
After the dicussions with Jakub Narebski I realized we aren't as
lenient in parsing hex strings as C Git is. So make it so.
I also added some tests for the lower level parts of the native
protocol, the pkt-line format. Testing is still far from complete
in this area of the code, but we're slightly better now.
Shawn O. Pearce (7):
Move hex parsing functions to RawParseUtil, accept upper case
Disambiguate pkt-line "0000" from "0004"
Move PacketLineIn hex parsing to RawParseUtils
Add tests for RawParseUtil's hex string parsing
Add tests for PacketLineIn
Add tests for PacketLineOut
Add tests for SideBandOutputStream
.../tst/org/spearce/jgit/lib/T0001_ObjectId.java | 10 +-
.../spearce/jgit/transport/PacketLineInTest.java | 262 ++++++++++++++++++++
.../spearce/jgit/transport/PacketLineOutTest.java | 175 +++++++++++++
.../jgit/transport/SideBandOutputStreamTest.java | 146 +++++++++++
.../jgit/util/RawParseUtils_HexParseTest.java | 158 ++++++++++++
.../org/spearce/jgit/lib/AbbreviatedObjectId.java | 8 +-
.../src/org/spearce/jgit/lib/AnyObjectId.java | 36 ---
.../src/org/spearce/jgit/lib/MutableObjectId.java | 11 +-
.../src/org/spearce/jgit/lib/ObjectId.java | 19 +-
.../spearce/jgit/transport/BasePackConnection.java | 5 +-
.../jgit/transport/BasePackPushConnection.java | 2 +-
.../org/spearce/jgit/transport/DaemonClient.java | 5 +-
.../org/spearce/jgit/transport/PacketLineIn.java | 44 +---
.../org/spearce/jgit/transport/ReceivePack.java | 6 +-
.../src/org/spearce/jgit/transport/UploadPack.java | 4 +-
.../src/org/spearce/jgit/util/RawParseUtils.java | 110 ++++++++-
16 files changed, 893 insertions(+), 108 deletions(-)
create mode 100644 org.spearce.jgit.test/tst/org/spearce/jgit/transport/PacketLineInTest.java
create mode 100644 org.spearce.jgit.test/tst/org/spearce/jgit/transport/PacketLineOutTest.java
create mode 100644 org.spearce.jgit.test/tst/org/spearce/jgit/transport/SideBandOutputStreamTest.java
create mode 100644 org.spearce.jgit.test/tst/org/spearce/jgit/util/RawParseUtils_HexParseTest.java
next reply other threads:[~2009-06-04 21:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-04 21:43 Shawn O. Pearce [this message]
2009-06-04 21:43 ` [JGIT PATCH 1/7] Move hex parsing functions to RawParseUtil, accept upper case Shawn O. Pearce
2009-06-04 21:43 ` [JGIT PATCH 2/7] Disambiguate pkt-line "0000" from "0004" Shawn O. Pearce
2009-06-04 21:43 ` [JGIT PATCH 3/7] Move PacketLineIn hex parsing to RawParseUtils Shawn O. Pearce
2009-06-04 21:44 ` [JGIT PATCH 4/7] Add tests for RawParseUtil's hex string parsing Shawn O. Pearce
2009-06-04 21:44 ` [JGIT PATCH 5/7] Add tests for PacketLineIn Shawn O. Pearce
2009-06-04 21:44 ` [JGIT PATCH 6/7] Add tests for PacketLineOut Shawn O. Pearce
2009-06-04 21:44 ` [JGIT PATCH 7/7] Add tests for SideBandOutputStream Shawn O. Pearce
2009-06-15 14:36 ` [JGIT PATCH 1/7] Move hex parsing functions to RawParseUtil, accept upper case Shawn O. Pearce
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1244151843-26954-1-git-send-email-spearce@spearce.org \
--to=spearce@spearce.org \
--cc=git@vger.kernel.org \
--cc=robin.rosenberg@dewire.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).