git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kjetil Barvik <barvik@broadpark.no>
To: git@vger.kernel.org
Cc: Johannes Schindelin <Johannes.Schindelin@gmx.de>,
	Kjetil Barvik <barvik@broadpark.no>
Subject: [PATCH v2] symlinks.c: small style cleanup
Date: Sun, 07 Jun 2009 16:43:56 +0200	[thread overview]
Message-ID: <1244385836-8540-1-git-send-email-barvik@broadpark.no> (raw)

Remove some unnecessary "return;"-statements at the end of "void
foo()"-functions.

Signed-off-by: Kjetil Barvik <barvik@broadpark.no>
---

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

> Hi,
>
> On Sun, 7 Jun 2009, Kjetil Barvik wrote:
>
>> Add {}-braces around an else-part, where the if-part already has
>> {}-braces.
>
> This is the wrong way round.  We prefer _not_ to add unnecessary
> braces, but do tolerate them from time to time.

  OK.  Have taken away that part of the patch in this verson (v2).

  -- kjetil


 symlinks.c |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)

diff --git a/symlinks.c b/symlinks.c
index 1d6b35b..64c8cd3 100644
--- a/symlinks.c
+++ b/symlinks.c
@@ -263,7 +263,6 @@ static void do_remove_scheduled_dirs(int new_len)
 			 removal.path[removal.len] != '/');
 	}
 	removal.len = new_len;
-	return;
 }
 
 void schedule_dir_for_removal(const char *name, int len)
@@ -296,11 +295,9 @@ void schedule_dir_for_removal(const char *name, int len)
 		       last_slash - match_len);
 		removal.len = last_slash;
 	}
-	return;
 }
 
 void remove_scheduled_dirs(void)
 {
 	do_remove_scheduled_dirs(0);
-	return;
 }
-- 
1.6.3.2.277.gd10543

                 reply	other threads:[~2009-06-07 14:45 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1244385836-8540-1-git-send-email-barvik@broadpark.no \
    --to=barvik@broadpark.no \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).