From: "Shawn O. Pearce" <spearce@spearce.org>
To: Robin Rosenberg <robin.rosenberg@dewire.com>
Cc: git@vger.kernel.org, Mark Struberg <struberg@yahoo.de>
Subject: [JGIT PATCH] Remove System.out.println from RevWalkFilterTest
Date: Tue, 16 Jun 2009 16:35:25 -0700 [thread overview]
Message-ID: <1245195326-9226-1-git-send-email-spearce@spearce.org> (raw)
JUnit tests shouldn't (in general) print to System.out, we already
have too much flooding the console when running a full test suite.
Instead assertions should be relied upon, which these tests
already have.
CC: Mark Struberg <struberg@yahoo.de>
Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
---
.../spearce/jgit/revwalk/RevWalkFilterTest.java | 3 ---
1 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/org.spearce.jgit.test/tst/org/spearce/jgit/revwalk/RevWalkFilterTest.java b/org.spearce.jgit.test/tst/org/spearce/jgit/revwalk/RevWalkFilterTest.java
index e2c813a..5aa648a 100644
--- a/org.spearce.jgit.test/tst/org/spearce/jgit/revwalk/RevWalkFilterTest.java
+++ b/org.spearce.jgit.test/tst/org/spearce/jgit/revwalk/RevWalkFilterTest.java
@@ -241,7 +241,6 @@ public void testCommitTimeRevFilter() throws Exception {
{
RevFilter after = CommitTimeRevFilter.after(since);
assertNotNull(after);
- System.out.println(after.toString());
rw.setRevFilter(after);
markStart(e);
assertCommit(e, rw.next());
@@ -254,7 +253,6 @@ public void testCommitTimeRevFilter() throws Exception {
{
RevFilter before = CommitTimeRevFilter.before(until);
assertNotNull(before);
- System.out.println(before.toString());
rw.reset();
rw.setRevFilter(before);
markStart(e);
@@ -268,7 +266,6 @@ public void testCommitTimeRevFilter() throws Exception {
{
RevFilter between = CommitTimeRevFilter.between(since, until);
assertNotNull(between);
- System.out.println(between.toString());
rw.reset();
rw.setRevFilter(between);
markStart(e);
--
1.6.3.2.406.gd6a466
reply other threads:[~2009-06-16 23:35 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1245195326-9226-1-git-send-email-spearce@spearce.org \
--to=spearce@spearce.org \
--cc=git@vger.kernel.org \
--cc=robin.rosenberg@dewire.com \
--cc=struberg@yahoo.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).