git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [JGIT PATCH] Remove System.out.println from RevWalkFilterTest
@ 2009-06-16 23:35 Shawn O. Pearce
  0 siblings, 0 replies; only message in thread
From: Shawn O. Pearce @ 2009-06-16 23:35 UTC (permalink / raw)
  To: Robin Rosenberg; +Cc: git, Mark Struberg

JUnit tests shouldn't (in general) print to System.out, we already
have too much flooding the console when running a full test suite.
Instead assertions should be relied upon, which these tests
already have.

CC: Mark Struberg <struberg@yahoo.de>
Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
---
 .../spearce/jgit/revwalk/RevWalkFilterTest.java    |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)

diff --git a/org.spearce.jgit.test/tst/org/spearce/jgit/revwalk/RevWalkFilterTest.java b/org.spearce.jgit.test/tst/org/spearce/jgit/revwalk/RevWalkFilterTest.java
index e2c813a..5aa648a 100644
--- a/org.spearce.jgit.test/tst/org/spearce/jgit/revwalk/RevWalkFilterTest.java
+++ b/org.spearce.jgit.test/tst/org/spearce/jgit/revwalk/RevWalkFilterTest.java
@@ -241,7 +241,6 @@ public void testCommitTimeRevFilter() throws Exception {
 		{
 			RevFilter after = CommitTimeRevFilter.after(since);
 			assertNotNull(after);
-			System.out.println(after.toString());
 			rw.setRevFilter(after);
 			markStart(e);
 			assertCommit(e, rw.next());
@@ -254,7 +253,6 @@ public void testCommitTimeRevFilter() throws Exception {
 		{
 			RevFilter before = CommitTimeRevFilter.before(until);
 			assertNotNull(before);
-			System.out.println(before.toString());
 			rw.reset();
 			rw.setRevFilter(before);
 			markStart(e);
@@ -268,7 +266,6 @@ public void testCommitTimeRevFilter() throws Exception {
 		{
 			RevFilter between = CommitTimeRevFilter.between(since, until);
 			assertNotNull(between);
-			System.out.println(between.toString());
 			rw.reset();
 			rw.setRevFilter(between);
 			markStart(e);
-- 
1.6.3.2.406.gd6a466

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2009-06-16 23:35 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-06-16 23:35 [JGIT PATCH] Remove System.out.println from RevWalkFilterTest Shawn O. Pearce

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).