From: newren@gmail.com
To: git@vger.kernel.org
Cc: Johannes.Schindelin@gmx.de, kusmabite@gmail.com,
Elijah Newren <newren@gmail.com>
Subject: [PATCH v2] fast-export: Make sure we show actual ref names instead of "(null)"
Date: Mon, 22 Jun 2009 07:06:37 -0600 [thread overview]
Message-ID: <1245676001-14734-3-git-send-email-newren@gmail.com> (raw)
In-Reply-To: <1245676001-14734-1-git-send-email-newren@gmail.com>
From: Elijah Newren <newren@gmail.com>
Under some cases (e.g. 'git fast-export --parents master -- COPYING' run
in git.git), the output included the lines
reset (null)
commit (null)
instead of
reset refs/heads/master
commit refs/heads/master
This simple change fixes that.
Signed-off-by: Elijah Newren <newren@gmail.com>
---
(No change to this patch since the first series.)
As noted above, run 'git fast-export --parents master -- COPYING' in
git.git to see this bug triggered.
builtin-fast-export.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/builtin-fast-export.c b/builtin-fast-export.c
index 891e2d4..9aa409b 100644
--- a/builtin-fast-export.c
+++ b/builtin-fast-export.c
@@ -531,6 +531,7 @@ int cmd_fast_export(int argc, const char **argv, const char *prefix)
get_tags_and_duplicates(&revs.pending, &extra_refs);
revs.topo_order = 1;
+ revs.show_source = 1;
if (prepare_revision_walk(&revs))
die("revision walk setup failed");
revs.diffopt.format_callback = show_filemodify;
--
1.6.0.6
next prev parent reply other threads:[~2009-06-22 13:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-22 13:06 A few fast export fixups -- round 2 newren
2009-06-22 13:06 ` [PATCH v2] fast-export: Omit tags that tag trees newren
2009-06-22 18:33 ` Junio C Hamano
2009-06-22 13:06 ` newren [this message]
2009-06-22 18:34 ` [PATCH v2] fast-export: Make sure we show actual ref names instead of "(null)" Junio C Hamano
2009-06-22 13:06 ` [PATCH v2] fast-export: Do parent rewriting to avoid dropping relevant commits newren
2009-06-22 13:06 ` [PATCH v2] fast-export: Add a --tag-of-filtered-object option for newly dangling tags newren
2009-06-22 18:34 ` Junio C Hamano
2009-06-26 4:45 ` Elijah Newren
2009-06-22 13:06 ` [PATCH v2] Add new fast-export testcases newren
2009-06-22 13:06 ` [PATCH v2] fast-export: Document the fact that git-rev-list arguments are accepted newren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1245676001-14734-3-git-send-email-newren@gmail.com \
--to=newren@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=kusmabite@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).