git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
To: git@vger.kernel.org
Cc: Jakub Narebski <jnareb@gmail.com>,
	Junio C Hamano <gitster@pobox.com>, Petr Baudis <pasky@suse.cz>,
	Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
Subject: [PATCHv8 3/7] gitweb: use git_print_authorship_rows in 'tag' view too
Date: Tue, 30 Jun 2009 00:00:50 +0200	[thread overview]
Message-ID: <1246312854-3365-4-git-send-email-giuseppe.bilotta@gmail.com> (raw)
In-Reply-To: <1246312854-3365-3-git-send-email-giuseppe.bilotta@gmail.com>

parse_tag must be adapted to use the hash keys expected by
git_print_authorship_rows. This is not a problem since git_tag is the
only user of this sub.

Signed-off-by: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
---
 gitweb/gitweb.perl |   16 +++++++++-------
 1 files changed, 9 insertions(+), 7 deletions(-)

diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index 9a8d775..a393ac6 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -2409,8 +2409,14 @@ sub parse_tag {
 			$tag{'name'} = $1;
 		} elsif ($line =~ m/^tagger (.*) ([0-9]+) (.*)$/) {
 			$tag{'author'} = $1;
-			$tag{'epoch'} = $2;
-			$tag{'tz'} = $3;
+			$tag{'author_epoch'} = $2;
+			$tag{'author_tz'} = $3;
+			if ($tag{'author'} =~ m/^([^<]+) <([^>]*)>/) {
+				$tag{'author_name'}  = $1;
+				$tag{'author_email'} = $2;
+			} else {
+				$tag{'author_name'} = $tag{'author'};
+			}
 		} elsif ($line =~ m/--BEGIN/) {
 			push @comment, $line;
 			last;
@@ -4620,11 +4626,7 @@ sub git_tag {
 	                                      $tag{'type'}) . "</td>\n" .
 	      "</tr>\n";
 	if (defined($tag{'author'})) {
-		my %ad = parse_date($tag{'epoch'}, $tag{'tz'});
-		print "<tr><td>author</td><td>" . esc_html($tag{'author'}) . "</td></tr>\n";
-		print "<tr><td></td><td>" . $ad{'rfc2822'} .
-			sprintf(" (%02d:%02d %s)", $ad{'hour_local'}, $ad{'minute_local'}, $ad{'tz_local'}) .
-			"</td></tr>\n";
+		git_print_authorship_rows(\%tag, 'author');
 	}
 	print "</table>\n\n" .
 	      "</div>\n";
-- 
1.6.3.rc1.192.gdbfcb

  reply	other threads:[~2009-06-29 22:01 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-29 22:00 [PATCHv8 0/7] gitweb: avatar support Giuseppe Bilotta
2009-06-29 22:00 ` [PATCHv8 1/7] gitweb: refactor author name insertion Giuseppe Bilotta
2009-06-29 22:00   ` [PATCHv8 2/7] gitweb: uniform author info for commit and commitdiff Giuseppe Bilotta
2009-06-29 22:00     ` Giuseppe Bilotta [this message]
2009-06-29 22:00       ` [PATCHv8 4/7] gitweb: (gr)avatar support Giuseppe Bilotta
2009-06-29 22:00         ` [PATCHv8 5/7] gitweb: gravatar url cache Giuseppe Bilotta
2009-06-29 22:00           ` [PATCHv8 6/7] gitweb: picon avatar provider Giuseppe Bilotta
2009-06-29 22:00             ` [PATCHv8 7/7] gitweb: add empty alt text to avatar img Giuseppe Bilotta
2009-06-30 20:29               ` Jakub Narebski
2009-06-30 20:23             ` [PATCHv8 6/7] gitweb: picon avatar provider Jakub Narebski
2009-06-30 20:50               ` Giuseppe Bilotta
2009-06-30 20:18           ` [PATCHv8 5/7] gitweb: gravatar url cache Jakub Narebski
2009-06-30 20:38           ` Junio C Hamano
2009-06-30 20:52             ` Giuseppe Bilotta
2009-06-30 20:16         ` [PATCHv8 4/7] gitweb: (gr)avatar support Jakub Narebski
2009-06-30 20:10       ` [PATCHv8 3/7] gitweb: use git_print_authorship_rows in 'tag' view too Jakub Narebski
2009-06-30 20:04     ` [PATCHv8 2/7] gitweb: uniform author info for commit and commitdiff Jakub Narebski
2009-06-30 20:04   ` [PATCHv8 1/7] gitweb: refactor author name insertion Jakub Narebski
2009-06-30 20:23     ` Giuseppe Bilotta
2009-06-30 21:08       ` Jakub Narebski
2009-06-30 23:15         ` Giuseppe Bilotta
2009-07-01  7:41           ` Jakub Narebski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1246312854-3365-4-git-send-email-giuseppe.bilotta@gmail.com \
    --to=giuseppe.bilotta@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=jnareb@gmail.com \
    --cc=pasky@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).