git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [JGIT PATCH] BlobBasedConfig now does not print stacktrace to stderr if blob is not found by path
@ 2009-07-01 17:25 Constantine Plotnikov
  0 siblings, 0 replies; only message in thread
From: Constantine Plotnikov @ 2009-07-01 17:25 UTC (permalink / raw)
  To: git; +Cc: Constantine Plotnikov

Prior to this patch, if the blob is not found inside commit by path,
an exception stack trace was printed to stderr. This patch suppress
this behavior by throwing FileNotFoundException instead of generic
IOException in order to make it more aligned with FileBasedConfig.

Signed-off-by: Constantine Plotnikov <constantine.plotnikov@gmail.com>
---
 .../src/org/spearce/jgit/lib/BlobBasedConfig.java  |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/org.spearce.jgit/src/org/spearce/jgit/lib/BlobBasedConfig.java b/org.spearce.jgit/src/org/spearce/jgit/lib/BlobBasedConfig.java
index 1f44994..8763c6c 100644
--- a/org.spearce.jgit/src/org/spearce/jgit/lib/BlobBasedConfig.java
+++ b/org.spearce.jgit/src/org/spearce/jgit/lib/BlobBasedConfig.java
@@ -37,6 +37,7 @@
 package org.spearce.jgit.lib;
 
 import java.io.ByteArrayInputStream;
+import java.io.FileNotFoundException;
 import java.io.IOException;
 import java.io.InputStream;
 import java.util.concurrent.Callable;
@@ -118,7 +119,7 @@ this(base, new Callable<byte[]>() {
 				final Repository r = commit.getRepository();
 				final TreeWalk tree = TreeWalk.forPath(r, path, treeId);
 				if (tree == null) {
-					throw new IOException("Entry not found by path: " + path);
+					throw new FileNotFoundException("Entry not found by path: " + path);
 				}
 				ObjectId blobId = tree.getObjectId(0);
 				ObjectLoader loader = tree.getRepository().openBlob(blobId);
-- 
1.6.1.2

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2009-07-01 17:26 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-07-01 17:25 [JGIT PATCH] BlobBasedConfig now does not print stacktrace to stderr if blob is not found by path Constantine Plotnikov

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).