git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Kristoffer Haugsbakk" <kristofferhaugsbakk@fastmail.com>
To: "Josh Soref" <gitgitgadget@gmail.com>, git@vger.kernel.org
Cc: blanet <bupt_xingxin@163.com>, "Xing Xin" <xingxin.xx@bytedance.com>
Subject: Re: [PATCH] Documentation/gitprotocol-v2.txt: fix a slight inconsistency in format
Date: Thu, 10 Oct 2024 15:38:46 +0200	[thread overview]
Message-ID: <12469838-46f2-474e-bc0c-8e3be37887c1@app.fastmail.com> (raw)
In-Reply-To: <pull.1807.git.git.1728566443089.gitgitgadget@gmail.com>

On Thu, Oct 10, 2024, at 15:20, blanet via GitGitGadget wrote:
> From: Xing Xin <xingxin.xx@bytedance.com>
>
> Signed-off-by: Xing Xin <xingxin.xx@bytedance.com>
> ---
>     Documentation/gitprotocol-v2.txt fix a slight inconsistency in format
>
> Published-As: 
> https://github.com/gitgitgadget/git/releases/tag/pr-git-1807%2Fblanet%2Fxx%2Fdoc-format-v1
> Fetch-It-Via: git fetch https://github.com/gitgitgadget/git 
> pr-git-1807/blanet/xx/doc-format-v1
> Pull-Request: https://github.com/git/git/pull/1807
>
>  Documentation/gitprotocol-v2.txt | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/gitprotocol-v2.txt b/Documentation/gitprotocol-v2.txt
> index 414bc625d5d..ca83b2ecc54 100644
> --- a/Documentation/gitprotocol-v2.txt
> +++ b/Documentation/gitprotocol-v2.txt
> @@ -527,8 +527,8 @@ a request.
> 
>  The provided options must not contain a NUL or LF character.
> 
> - object-format
> -~~~~~~~~~~~~~~~
> +object-format
> +~~~~~~~~~~~~~
> 
>  The server can advertise the `object-format` capability with a value 
> `X` (in the
>  form `object-format=X`) to notify the client that the server is able 
> to deal
>
> base-commit: 777489f9e09c8d0dd6b12f9d90de6376330577a2
> -- 
> gitgitgadget

I can confirm that this is the only heading in this document which is
like this (setext length (name?) is not the same as the length of the
title/header).  Also the only place where the title is not flushed to
the left.  Well-scoped change.

-- 
Kristoffer

  reply	other threads:[~2024-10-10 13:39 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-10 13:20 [PATCH] Documentation/gitprotocol-v2.txt: fix a slight inconsistency in format blanet via GitGitGadget
2024-10-10 13:38 ` Kristoffer Haugsbakk [this message]
2024-10-10 18:52   ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=12469838-46f2-474e-bc0c-8e3be37887c1@app.fastmail.com \
    --to=kristofferhaugsbakk@fastmail.com \
    --cc=bupt_xingxin@163.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=xingxin.xx@bytedance.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).