From: "Shawn O. Pearce" <spearce@spearce.org>
To: Robin Rosenberg <robin.rosenberg@dewire.com>
Cc: git@vger.kernel.org
Subject: [JGIT PATCH 00/12] Cleanup Config class
Date: Tue, 21 Jul 2009 13:19:18 -0700 [thread overview]
Message-ID: <1248207570-13880-1-git-send-email-spearce@spearce.org> (raw)
Misc. cleanups of the Config class (aka the base class for
RepositoryConfig) to make the code easier to follow. I came
about this series because I started to do improvements to the
Config class to better support submodule introspection from a bare
repository... and I realized this code was a mess.
This series (or at least the first patch of it) applies on top of
my prior 11 patch series for alternate object database improvements.
Shawn O. Pearce (12):
Use NB.readFully(File) to slurp complete file contents
Correct name of fileRead member of Config class
Add setLong to Config
Fix Config setInt(..., 0) to store "0" not "0 g"
Rename Config.unsetString to just unset()
Remove pointless null assignments in Config
Clarify section and subsection values in Config code
Don't subclass PrintWriter when writing the Config
Use a Java 5 style iteration over the Config entries list
Match config subsection names using case sensitive search
Cleanup Config's MAGIC_EMPTY_VALUE to be more safe
Remove unreferenced REMOTE_SECTION from RepositoryConfig
.../src/org/spearce/jgit/lib/Config.java | 196 +++++++++++---------
.../src/org/spearce/jgit/lib/FileBasedConfig.java | 7 +-
.../src/org/spearce/jgit/lib/RefDatabase.java | 15 +-
.../src/org/spearce/jgit/lib/ReflogReader.java | 32 +---
.../src/org/spearce/jgit/lib/RepositoryCache.java | 20 +-
.../src/org/spearce/jgit/lib/RepositoryConfig.java | 4 -
.../org/spearce/jgit/lib/UnpackedObjectLoader.java | 15 +--
.../org/spearce/jgit/transport/RemoteConfig.java | 2 +-
org.spearce.jgit/src/org/spearce/jgit/util/NB.java | 52 +++++
9 files changed, 195 insertions(+), 148 deletions(-)
next reply other threads:[~2009-07-21 20:21 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-21 20:19 Shawn O. Pearce [this message]
2009-07-21 20:19 ` [JGIT PATCH 01/12] Use NB.readFully(File) to slurp complete file contents Shawn O. Pearce
2009-07-21 20:19 ` [JGIT PATCH 02/12] Correct name of fileRead member of Config class Shawn O. Pearce
2009-07-21 20:19 ` [JGIT PATCH 03/12] Add setLong to Config Shawn O. Pearce
2009-07-21 20:19 ` [JGIT PATCH 04/12] Fix Config setInt(..., 0) to store "0" not "0 g" Shawn O. Pearce
2009-07-21 20:19 ` [JGIT PATCH 05/12] Rename Config.unsetString to just unset() Shawn O. Pearce
2009-07-21 20:19 ` [JGIT PATCH 06/12] Remove pointless null assignments in Config Shawn O. Pearce
2009-07-21 20:19 ` [JGIT PATCH 07/12] Clarify section and subsection values in Config code Shawn O. Pearce
2009-07-21 20:19 ` [JGIT PATCH 08/12] Don't subclass PrintWriter when writing the Config Shawn O. Pearce
2009-07-21 20:19 ` [JGIT PATCH 09/12] Use a Java 5 style iteration over the Config entries list Shawn O. Pearce
2009-07-21 20:19 ` [JGIT PATCH 10/12] Match config subsection names using case sensitive search Shawn O. Pearce
2009-07-21 20:19 ` [JGIT PATCH 11/12] Cleanup Config's MAGIC_EMPTY_VALUE to be more safe Shawn O. Pearce
2009-07-21 20:19 ` [JGIT PATCH 12/12] Remove unreferenced REMOTE_SECTION from RepositoryConfig Shawn O. Pearce
2009-07-21 21:51 ` [JGIT PATCH 11/12] Cleanup Config's MAGIC_EMPTY_VALUE to be more safe Robin Rosenberg
2009-07-21 21:54 ` Shawn O. Pearce
2009-07-22 11:11 ` [JGIT PATCH 10/12] Match config subsection names using case sensitive search Constantine Plotnikov
2009-07-22 21:37 ` Robin Rosenberg
2009-07-24 21:34 ` [PATCH] Ensure Config readers handle case insensitive names correctly Shawn O. Pearce
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1248207570-13880-1-git-send-email-spearce@spearce.org \
--to=spearce@spearce.org \
--cc=git@vger.kernel.org \
--cc=robin.rosenberg@dewire.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).