From: "SZEDER Gábor" <szeder@ira.uka.de>
To: git@vger.kernel.org
Cc: "Shawn O. Pearce" <spearce@spearce.org>,
"Thomas Rast" <trast@student.ethz.ch>,
"SZEDER Gábor" <szeder@ira.uka.de>
Subject: [PATCH] bash: gitk accepts common log-shortlog options
Date: Tue, 21 Jul 2009 17:20:02 -0500 [thread overview]
Message-ID: <1248214802-2996-1-git-send-email-szeder@ira.uka.de> (raw)
Commit a393777e (bash completion: refactor common log, shortlog and gitk
options, 2009-02-16) introduced a list of command line options that go
well with 'git log' and 'git shortlog' but not with gitk. However,
these options are all 'git rev-list' options, and, therefore, are
accepted by gitk, too.
This patch moves these options to the list of common options, making
them available for gitk option completion, too. Since the list of
log-shortlog options becomes empty with this move, this patch deletes
it.
Signed-off-by: SZEDER Gábor <szeder@ira.uka.de>
---
contrib/completion/git-completion.bash | 9 ++-------
1 files changed, 2 insertions(+), 7 deletions(-)
diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
index bc2d8b4..f0cd5e3 100755
--- a/contrib/completion/git-completion.bash
+++ b/contrib/completion/git-completion.bash
@@ -1118,6 +1118,8 @@ __git_log_common_options="
--max-count=
--max-age= --since= --after=
--min-age= --until= --before=
+ --author= --committer= --grep=
+ --all-match
"
# Options that go well for log and gitk (not shortlog)
__git_log_gitk_options="
@@ -1125,11 +1127,6 @@ __git_log_gitk_options="
--simplify-merges --simplify-by-decoration
--left-right
"
-# Options that go well for log and shortlog (not gitk)
-__git_log_shortlog_options="
- --author= --committer= --grep=
- --all-match
-"
__git_log_pretty_formats="oneline short medium full fuller email raw format:"
__git_log_date_formats="relative iso8601 rfc2822 short local default raw"
@@ -1162,7 +1159,6 @@ _git_log ()
--*)
__gitcomp "
$__git_log_common_options
- $__git_log_shortlog_options
$__git_log_gitk_options
--root --topo-order --date-order --reverse
--follow --full-diff
@@ -1822,7 +1818,6 @@ _git_shortlog ()
--*)
__gitcomp "
$__git_log_common_options
- $__git_log_shortlog_options
--numbered --summary
"
return
--
1.6.4.rc1.73.ga0daf
next reply other threads:[~2009-07-21 22:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-21 22:20 SZEDER Gábor [this message]
2009-07-21 22:36 ` [PATCH] bash: gitk accepts common log-shortlog options Thomas Rast
2009-07-22 14:05 ` SZEDER Gábor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1248214802-2996-1-git-send-email-szeder@ira.uka.de \
--to=szeder@ira.uka.de \
--cc=git@vger.kernel.org \
--cc=spearce@spearce.org \
--cc=trast@student.ethz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).