git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mattias Nissler <mattias.nissler@gmx.de>
To: Eric Wong <normalperson@yhbt.net>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [ANNOUNCE] GIT 1.6.4-rc2
Date: Sat, 25 Jul 2009 22:16:58 +0200	[thread overview]
Message-ID: <1248553018.4593.15.camel@kea> (raw)
In-Reply-To: <20090725192230.GA11510@dcvr.yhbt.net>

On Sat, 2009-07-25 at 12:22 -0700, Eric Wong wrote:
> Mattias Nissler <mattias.nissler@gmx.de> wrote:
> > Maybe we should rather try to detect whether we have read access to the
> > repository root and adjust behaviour accordingly? Or at least print a
> > warning when cloning restricted multi-branch repos, since this just
> > fails silently (doesn't pick up any branches) when you have minimize_url
> > enabled.
> 
> We actually try that in Git::SVN::Ra::minimize_url:
> 
> sub minimize_url {
> 	my ($self) = @_;
> 	return $self->{url} if ($self->{url} eq $self->{repos_root});
> 	my $url = $self->{repos_root};
> 	my @components = split(m!/!, $self->{svn_path});
> 	my $c = '';
> 	do {
> 		$url .= "/$c" if length $c;
> 		eval { (ref $self)->new($url)->get_latest_revnum };
> 	} while ($@ && ($c = shift @components));
> 	$url;
> }
> 
> Maybe get_latest_revnum() isn't strong enough of a check for
> certain setups and get_log() needs to be used instead?

Well, I simply wasn't aware of this. I've just retried and it turns out
latest git.git works perfectly for me in both restricted and
non-restricted setups. Great work!

Mattias

  reply	other threads:[~2009-07-25 20:18 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-23  6:40 [ANNOUNCE] GIT 1.6.4-rc2 Junio C Hamano
2009-07-23 16:32 ` Tony Finch
2009-07-24  9:38 ` Eric Wong
2009-07-24 17:49   ` Junio C Hamano
2009-07-25 10:38     ` Eric Wong
2009-07-25 11:10       ` [PATCH 2/2] git svn: the branch command no longer needs the full path Eric Wong
2009-07-26  8:13         ` Junio C Hamano
2009-07-26 10:01           ` [PATCH] t9143: do not fail if Compress::Zlib is missing Eric Wong
2009-07-25 13:39       ` [ANNOUNCE] GIT 1.6.4-rc2 Mattias Nissler
2009-07-25 19:22         ` Eric Wong
2009-07-25 20:16           ` Mattias Nissler [this message]
2009-07-25 20:57             ` [PATCH] git svn: make minimize URL more reliable over http(s) Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1248553018.4593.15.camel@kea \
    --to=mattias.nissler@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=normalperson@yhbt.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).