From: Thell Fowler <tbfowler4@gmail.com>
To: git@vger.kernel.org
Subject: [RFC] Allowing new eof whitelines while still doing whitespace trailing-space fix.
Date: Sat, 01 Aug 2009 11:53:44 -0500 [thread overview]
Message-ID: <1249145624.2774.16.camel@GWPortableVCS> (raw)
As part of a current mirroring project of a dirty upstream repo that has
mixed line endings and leading/trailing whitespace issues it became
apparent that the current trailing-space fixing in ws.c worked
correctly, but the new_blank_lines_at_end processing in builtin-apply.c
would remove the newly fixed line. Also, as noted in a previous thread,
there are times when adding new whitelines at eof is a needed
capability, yet the desire remains to correct other whitespace issues
within the patch.
The patch in the follow-up post is an attempt to fix that. This is my
first git-core patch, so please be honest but gentle. :P If the fix is
of interest I'd be glad to go through the steps of making a test case
and whatever else is needed.
next reply other threads:[~2009-08-01 16:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-01 16:53 Thell Fowler [this message]
2009-08-01 22:12 ` [PATCH] Add --allow-eof-whitelines to git-apply while still doing whitespace trailing-space fixing TBFowler
2009-08-01 22:14 ` [RFC] Allowing new eof whitelines while still doing whitespace trailing-space fix Thell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1249145624.2774.16.camel@GWPortableVCS \
--to=tbfowler4@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).