git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sverre Rabbelier <srabbelier@gmail.com>
To: "Shawn O. Pearce" <spearce@spearce.org>,
	"Johannes Schindelin" <Johannes.Schindelin@gmx.de>,
	"Git List" <git@vger.kernel.org>
Subject: [RFC PATCH 0/3] fast-import: add option command
Date: Sat,  1 Aug 2009 22:06:07 -0700	[thread overview]
Message-ID: <1249189570-26576-1-git-send-email-srabbelier@gmail.com> (raw)
In-Reply-To: <fabb9a1e0908011829j3843c132ka5081d994aad973f@mail.gmail.com>

Because I am too impatient to wait for a reply to my earlier mail,
here is an RFC series that demonstrates how I envision the option
command to work.

>From the second patch:

    This allows the frontend to specify any of the supported options as
    long as no non-option command has been given. This way the
    user does not have to include any frontend-specific options, but
    instead she can rely on the frontend to tell fast-import what it
    needs.

This change of course means that old fast-import clients will break
upon receiving an 'option' command (or with an argument they don't
support), but such clients will break with a clear output stating
the reason for the breakage. Newer frontends therefore should only
output options if the user tells them to (by means of a flag/config
option), or at least allow disabling option output.

The main use case for this is hg-git, which I want to modify so that
it uses 'hg fast-export | git fast-import' for the intial import.
However, to do that I need the fast-import part to write a marks
file, that is, --write-marks=git.marks. To simplify this process for
the user, it would be nice if 'hg fast-export' can instead emit an
'option write-marks git.marks' line (hence the test case).

 Sverre Rabbelier (3):
      fast-import: put option parsing code in seperate functions
      fast-import: add option command
      fast-import: test the new option command

 fast-import.c          |  137 ++++++++++++++++++++++++++++++++++++-----------
 t/t9300-fast-import.sh |   33 ++++++++++++
 2 files changed, 138 insertions(+), 32 deletions(-)

  reply	other threads:[~2009-08-02  5:07 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-02  1:29 option directive to fast-import Sverre Rabbelier
2009-08-02  5:06 ` Sverre Rabbelier [this message]
2009-08-02  5:06   ` [RFC PATCH 1/2] fast-import: put option parsing code in seperate functions Sverre Rabbelier
2009-08-02  5:06     ` [RFC PATCH 2/2] fast-import: add option command Sverre Rabbelier
2009-08-02  5:06       ` [RFC PATCH 3/3] fast-import: test the new " Sverre Rabbelier
2009-08-02  7:09     ` [RFC PATCH v1a 1/3] fast-import: put option parsing code in seperate functions Sverre Rabbelier
2009-08-03  0:15   ` [RFC PATCH 0/3] fast-import: add option command Shawn O. Pearce
2009-08-03  4:31     ` Sverre Rabbelier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1249189570-26576-1-git-send-email-srabbelier@gmail.com \
    --to=srabbelier@gmail.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=spearce@spearce.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).