git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Thell Fowler <tbfowler4@gmail.com>
To: Nanako Shiraishi <nanako3@lavabit.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Add --allow-eof-whitelines to git-apply while still doing  whitespace trailing-space fixing.
Date: Tue, 04 Aug 2009 19:15:37 -0500	[thread overview]
Message-ID: <1249431338.2774.59.camel@GWPortableVCS> (raw)
In-Reply-To: <20090805061519.6117@nanako3.lavabit.com>

On Wed, 2009-08-05 at 06:15 +0900, Nanako Shiraishi wrote:
> Quoting Thell Fowler <tbfowler4@gmail.com>
> 
> >   - Added --allow-eof-whitelines to git apply to short-circuit removal
> > of new empty lines when tailing-space is set.
> >   - Added pass-through to apply from git-am.sh
> >   - Added pass-through to git-am from git-rebase.sh
> >   - Added the auto-completion entries.
> >
> > Signed-off-by: TBFowler <thell@almostautomated.com>
> 
> I like this new feature. However, this topic came up last week, and Junio said that whitespace checking should be controlled with the attributes mechanism.
> 
> http://thread.gmane.org/gmane.comp.version-control.git/124113/focus=124138
> 
Seemed that the issue/resolution was still open for discussion.
http://thread.gmane.org/gmane.comp.version-control.git/124113/focus=124138

Should this be re-done as a whitespace attribute?


> Please do not talk "I did this, I did that" in your proposed commit log
> message.  From Documentation/SubmittingPatches:
> 
> 	- the body should provide a meaningful commit message, which:
> 		- uses the imperative, present tense: "change",
> 		  not "changed" or "changes".
> 		- includes motivation for the change, and contrasts
> 		  its implementation with previous behaviour
> 
> In other words, the messages are often written as if you are giving an order to the program to correct itself.
> 

Got it. ...'giving an order'...  and the motivation; should be easy to remember.

Thank you for the feedback and instruction.
Thell

  reply	other threads:[~2009-08-05  0:17 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-01 16:57 [PATCH] Add --allow-eof-whitelines to git-apply while still doing whitespace trailing-space fixing Thell Fowler
2009-08-04 21:15 ` Nanako Shiraishi
2009-08-05  0:15   ` Thell Fowler [this message]
  -- strict thread matches above, loose matches on Subject: below --
2009-08-01 16:53 [RFC] Allowing new eof whitelines while still doing whitespace trailing-space fix Thell Fowler
2009-08-01 22:12 ` [PATCH] Add --allow-eof-whitelines to git-apply while still doing whitespace trailing-space fixing TBFowler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1249431338.2774.59.camel@GWPortableVCS \
    --to=tbfowler4@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=nanako3@lavabit.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).