From: Luke Dashjr <luke-jr+git@utopios.org>
To: git@vger.kernel.org
Cc: Luke Dashjr <luke-jr+git@utopios.org>
Subject: [PATCH 5/5] Convert add_file_to_index's lstat failure from a die to an error
Date: Wed, 12 Aug 2009 22:20:24 -0500 [thread overview]
Message-ID: <1250133624-2272-5-git-send-email-luke-jr+git@utopios.org> (raw)
In-Reply-To: <1250133624-2272-4-git-send-email-luke-jr+git@utopios.org>
In order to make --ignore-errors able to ignore a lstat failure in
add_file_to_index, it needs to raise an error, NOT a fatal die.
Signed-off-by: Luke Dashjr <luke-jr+git@utopios.org>
---
read-cache.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/read-cache.c b/read-cache.c
index 4e3e272..074e6b8 100644
--- a/read-cache.c
+++ b/read-cache.c
@@ -638,7 +638,7 @@ int add_file_to_index(struct index_state *istate, const char *path, int flags)
{
struct stat st;
if (lstat(path, &st))
- die_errno("unable to stat '%s'", path);
+ return error_errno("unable to stat '%s'", path);
return add_to_index(istate, path, &st, flags);
}
--
1.6.3.3
next prev parent reply other threads:[~2009-08-13 3:21 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-12 22:26 For review: git add --ignore-unmatch Luke-Jr
2009-08-12 22:57 ` Thomas Rast
2009-08-13 3:20 ` [PATCH 1/5] port --ignore-unmatch to "git add" Luke Dashjr
2009-08-13 3:20 ` [PATCH 2/5] fix "git add --ignore-errors" to ignore pathspec errors Luke Dashjr
2009-08-13 3:20 ` [PATCH 3/5] Document --ignore-unmatch in git-add.txt Luke Dashjr
2009-08-13 3:20 ` [PATCH 4/5] implement error_errno and warning_errno Luke Dashjr
2009-08-13 3:20 ` Luke Dashjr [this message]
2009-08-13 19:38 ` [PATCH 2/5] fix "git add --ignore-errors" to ignore pathspec errors Junio C Hamano
2009-08-13 20:42 ` Luke-Jr
2009-08-13 21:02 ` [PATCH] port --ignore-unmatch to "git add" Luke Dashjr
2009-08-13 21:03 ` [PATCH] Document --ignore-unmatch in git-add.txt Luke Dashjr
2009-08-13 19:36 ` [PATCH 1/5] port --ignore-unmatch to "git add" Junio C Hamano
2009-08-13 20:40 ` Luke-Jr
2009-08-13 21:51 ` Alex Riesen
2009-08-13 21:06 ` Thomas Rast
2009-08-14 19:52 ` Junio C Hamano
2009-08-14 20:39 ` Luke-Jr
2009-08-14 20:47 ` Luke-Jr
2009-08-14 21:39 ` Nanako Shiraishi
2009-08-14 22:54 ` Luke-Jr
2009-10-10 17:23 ` Luke-Jr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1250133624-2272-5-git-send-email-luke-jr+git@utopios.org \
--to=luke-jr+git@utopios.org \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).