git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Frank Li <lznuaa@gmail.com>
To: git@vger.kernel.org, msysgit@googlegroups.com
Cc: Johannes.Schindelin@gmx.de, Frank Li <lznuaa@gmail.com>
Subject: [PATCH 03/11] Define SNPRINTF_SIZE_CORR 1 when use MSVC build git
Date: Tue, 18 Aug 2009 00:01:04 +0800	[thread overview]
Message-ID: <1250524872-5148-3-git-send-email-lznuaa@gmail.com> (raw)
In-Reply-To: <1250524872-5148-2-git-send-email-lznuaa@gmail.com>

There are not NUL at vsnprintf verstion of MSVC when rearch max len.
Define vsnprintf to _vsnprintf. vsnprintf have deprecated.

Signed-off-by: Frank Li <lznuaa@gmail.com>
---
 compat/snprintf.c |    7 ++++++-
 1 files changed, 6 insertions(+), 1 deletions(-)

diff --git a/compat/snprintf.c b/compat/snprintf.c
index 6c0fb05..47b2b8a 100644
--- a/compat/snprintf.c
+++ b/compat/snprintf.c
@@ -6,7 +6,7 @@
  * number of characters to write without the trailing NUL.
  */
 #ifndef SNPRINTF_SIZE_CORR
-#if defined(__MINGW32__) && defined(__GNUC__) && __GNUC__ < 4
+#if defined(__MINGW32__) && defined(__GNUC__) && __GNUC__ < 4 || defined(_MSC_VER)
 #define SNPRINTF_SIZE_CORR 1
 #else
 #define SNPRINTF_SIZE_CORR 0
@@ -14,6 +14,11 @@
 #endif
 
 #undef vsnprintf
+
+#if defined(_MSC_VER)
+#define vsnprintf _vsnprintf
+#endif
+
 int git_vsnprintf(char *str, size_t maxsize, const char *format, va_list ap)
 {
 	char *s;
-- 
1.6.4.msysgit.0

  reply	other threads:[~2009-08-17 16:02 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-17 16:01 [PATCH 01/11] Fix build failure at VC because function declare use old style at regex.c Frank Li
2009-08-17 16:01 ` [PATCH 02/11] Fix declare variable at mid of function Frank Li
2009-08-17 16:01   ` Frank Li [this message]
2009-08-17 16:01     ` [PATCH 04/11] Add _MSC_VER predefine macro to make same behaviors with __MINGW32__ Enable MSVC build. MSVC have the save behaviors with msysgit Frank Li
2009-08-17 16:38       ` Johannes Schindelin
2009-08-18  1:29         ` Frank Li
2009-08-18  5:06           ` tom fogal
2009-08-17 16:32     ` [PATCH 03/11] Define SNPRINTF_SIZE_CORR 1 when use MSVC build git Johannes Schindelin
2009-08-18  1:19       ` Frank Li
2009-08-18  9:31         ` Johannes Schindelin
2009-08-17 16:29   ` [PATCH 02/11] Fix declare variable at mid of function Johannes Schindelin
2009-08-17 16:34     ` Reece Dunn
2009-08-17 19:36       ` Johannes Schindelin
2009-08-18  5:23         ` [msysGit] " Marius Storm-Olsen
2009-08-18  9:34           ` Johannes Schindelin
2009-08-18 16:11             ` Frank Li
2009-08-18 16:52               ` Matthieu Moy
2009-08-19 10:15               ` Johannes Schindelin
2009-08-19 10:55                 ` Johannes Sixt
2009-08-19 13:15                   ` Johannes Schindelin
2009-08-19 15:21                     ` [msysGit] " Johannes Sixt
2009-08-17 19:28     ` Junio C Hamano
2009-08-17 21:00       ` [msysGit] " Johannes Schindelin
2009-08-17 21:38         ` Junio C Hamano
2009-08-17 16:26 ` [PATCH 01/11] Fix build failure at VC because function declare use old style at regex.c Johannes Schindelin
2009-08-18 15:03   ` Frank Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1250524872-5148-3-git-send-email-lznuaa@gmail.com \
    --to=lznuaa@gmail.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=msysgit@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).