From: Owen Taylor <otaylor@redhat.com>
To: git@vger.kernel.org
Cc: "Owen W. Taylor" <otaylor@fishsoup.net>
Subject: [PATCH 4/4] push: allow configuring default for --show-subjects
Date: Sun, 13 Sep 2009 19:31:25 -0400 [thread overview]
Message-ID: <1252884685-9169-5-git-send-email-otaylor@redhat.com> (raw)
In-Reply-To: <1252884685-9169-4-git-send-email-otaylor@redhat.com>
From: Owen W. Taylor <otaylor@fishsoup.net>
A new configuration variable push.show-subjects sets the default
behavior for whether 'git push' should show a commit synopsis with
each updated ref.
Signed-off-by: Owen W. Taylor <otaylor@fishsoup.net>
---
Documentation/config.txt | 4 ++++
builtin-push.c | 2 ++
cache.h | 1 +
config.c | 4 ++++
environment.c | 1 +
5 files changed, 12 insertions(+), 0 deletions(-)
diff --git a/Documentation/config.txt b/Documentation/config.txt
index 3bb632f..83bc5a5 100644
--- a/Documentation/config.txt
+++ b/Documentation/config.txt
@@ -1320,6 +1320,10 @@ push.default::
* `tracking` push the current branch to its upstream branch.
* `current` push the current branch to a branch of the same name.
+push.show-subjects::
+ If set to true, linkgit:git-push[1] will act as if the --show-subjects
+ option was passed, unless overriden with --no-show-subjects.
+
rebase.stat::
Whether to show a diffstat of what changed upstream since the last
rebase. False by default.
diff --git a/builtin-push.c b/builtin-push.c
index 7c9e394..e3dc579 100644
--- a/builtin-push.c
+++ b/builtin-push.c
@@ -197,6 +197,8 @@ int cmd_push(int argc, const char **argv, const char *prefix)
if (push_confirm)
flags |= TRANSPORT_PUSH_CONFIRM;
+ if (push_show_subjects)
+ flags |= TRANSPORT_PUSH_SHOW_SUBJECTS;
argc = parse_options(argc, argv, prefix, options, push_usage, 0);
diff --git a/cache.h b/cache.h
index ef8606d..9e6a1e6 100644
--- a/cache.h
+++ b/cache.h
@@ -559,6 +559,7 @@ extern enum branch_track git_branch_track;
extern enum rebase_setup_type autorebase;
extern enum push_default_type push_default;
extern int push_confirm;
+extern int push_show_subjects;
enum object_creation_mode {
OBJECT_CREATION_USES_HARDLINKS = 0,
diff --git a/config.c b/config.c
index 1bc8e6f..bc78876 100644
--- a/config.c
+++ b/config.c
@@ -597,6 +597,10 @@ static int git_default_push_config(const char *var, const char *value)
}
return 0;
}
+ if (!strcmp(var, "push.show-subjects")) {
+ push_show_subjects = git_config_bool(var, value);
+ return 0;
+ }
/* Add other config variables here and to Documentation/config.txt. */
return 0;
diff --git a/environment.c b/environment.c
index e1c82b9..303c54f 100644
--- a/environment.c
+++ b/environment.c
@@ -46,6 +46,7 @@ enum branch_track git_branch_track = BRANCH_TRACK_REMOTE;
enum rebase_setup_type autorebase = AUTOREBASE_NEVER;
int push_confirm;
enum push_default_type push_default = PUSH_DEFAULT_MATCHING;
+int push_show_subjects;
#ifndef OBJECT_CREATION_MODE
#define OBJECT_CREATION_MODE OBJECT_CREATION_USES_HARDLINKS
#endif
--
1.6.2.5
next prev parent reply other threads:[~2009-09-13 23:31 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-13 23:31 Patches for git-push --confirm and --show-subjects Owen Taylor
2009-09-13 23:31 ` [PATCH 1/4] push: add --confirm option to ask before sending updates Owen Taylor
2009-09-13 23:31 ` [PATCH 2/4] push: allow configuring default for --confirm Owen Taylor
2009-09-13 23:31 ` [PATCH 3/4] push: add --show-subjects option to show commit synopsis Owen Taylor
2009-09-13 23:31 ` Owen Taylor [this message]
2009-09-14 0:47 ` Patches for git-push --confirm and --show-subjects Junio C Hamano
2009-09-14 0:53 ` Junio C Hamano
2009-09-14 2:35 ` Owen Taylor
2009-09-14 22:21 ` Daniel Barkalow
2009-09-14 23:18 ` Owen Taylor
2009-09-15 0:46 ` Junio C Hamano
2009-09-15 2:38 ` Owen Taylor
2009-09-15 5:50 ` Junio C Hamano
2009-09-15 11:50 ` Owen Taylor
2009-09-15 0:55 ` Daniel Barkalow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1252884685-9169-5-git-send-email-otaylor@redhat.com \
--to=otaylor@redhat.com \
--cc=git@vger.kernel.org \
--cc=otaylor@fishsoup.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).