From: Junio C Hamano <gitster@pobox.com>
To: git@vger.kernel.org
Subject: [WIP PATCH 0/6] Merging with D/F conflicts
Date: Sat, 19 Sep 2009 22:06:09 -0700 [thread overview]
Message-ID: <1253423175-6339-1-git-send-email-gitster@pobox.com> (raw)
I have been working on this on-and-off and it still is not finished, but I
thought it would be a good place to stop, especially since this will not
be part of the upcoming 1.6.5 anyway.
The first three patches are preparatory clean-ups.
The fourth patch roughly corresponds to Linus's 880386c (Prepare
'traverse_trees()' for D/F conflict lookahead, 2009-09-06), but it does
implement multi-entry lookahead. It reveals why lookahead on the tree
side alone is not sufficient by breaking a few tests.
The fifth one starts to compensate for the change in the tree side by
preparing the side that walks the index for a similar lookahead mechanism,
but it does not actually implement the lookahead yet.
The last one is a debugging patch.
This change has to break the output order (but not content) of the
diff-index somewhat. If you had this:
Index Tree
b b-2/c
b-2 b/d
the expected output order from diff-index is b, b-2, b-2/c, then b/d. But
if you walk the tree and the index in parallel, we would end up showing b,
b/d, b-2 and then b-2/c. A sad part of the story is that diff-index
always emits D/F conflicted entries as two independent records, so it is
rather a bad match to the unpack_trees() framework to begin with.
The patches are designed to apply on 79b4fde (Merge branch 'maint',
2009-09-03).
Junio C Hamano (6):
diff-lib.c: fix misleading comments on oneway_diff()
unpack-trees: typofix
unpack_callback(): use unpack_failed() consistently
traverse_trees(): handle D/F conflict case sanely
unpack-trees.c: prepare for looking ahead in the index
read-tree --debug-unpack
builtin-read-tree.c | 36 +++++++
cache.h | 2 +
diff-lib.c | 20 +----
tree-walk.c | 277 +++++++++++++++++++++++++++++++++++++++++++--------
unpack-trees.c | 275 ++++++++++++++++++++++++++++++++++++++------------
unpack-trees.h | 3 +-
6 files changed, 484 insertions(+), 129 deletions(-)
next reply other threads:[~2009-09-20 5:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-20 5:06 Junio C Hamano [this message]
2009-09-20 5:06 ` [WIP PATCH 1/6] diff-lib.c: fix misleading comments on oneway_diff() Junio C Hamano
2009-09-20 5:06 ` [WIP PATCH 2/6] unpack-trees: typofix Junio C Hamano
2009-09-20 5:06 ` [WIP PATCH 3/6] unpack_callback(): use unpack_failed() consistently Junio C Hamano
2009-09-20 5:06 ` [WIP PATCH 4/6] traverse_trees(): handle D/F conflict case sanely Junio C Hamano
2009-09-20 5:06 ` [WIP PATCH 5/6] unpack-trees.c: prepare for looking ahead in the index Junio C Hamano
2009-09-20 5:06 ` [WIP PATCH 6/6] read-tree --debug-unpack Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1253423175-6339-1-git-send-email-gitster@pobox.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).