From: iler.ml@gmail.com
To: git@vger.kernel.org
Cc: iler.ml@gmail.com
Subject: [PATCH] fix obscure perl message when encryption=tls and smtp cannot connect.
Date: Sat, 26 Sep 2009 00:30:13 +0300 [thread overview]
Message-ID: <1253914213-22274-1-git-send-email-iler.ml@gmail.com> (raw)
When encryption=tls and smtp cannot connect, git-send-email prints following perl error:
Can't call method "command" on an undefined value at /usr/local/libexec/git-core/git-send-email line 927.
(ithis is when smtp host orport is misspelled, or network is down, and encryption is tls).
We expect some familiar "Cannot connect to SERVER:PORT" message.
Fix it to print normal "smtp can't connect" diagnostics.
--- /usr/local/libexec/git-core/git-send-email.000 2009-09-26 00:10:01.000000000 +0300
+++ /usr/local/libexec/git-core/git-send-email 2009-09-26 00:11:39.000000000 +0300
@@ -922,7 +922,7 @@
$smtp ||= Net::SMTP->new((defined $smtp_server_port)
? "$smtp_server:$smtp_server_port"
: $smtp_server);
- if ($smtp_encryption eq 'tls') {
+ if ($smtp_encryption eq 'tls' && $smtp) {
require Net::SMTP::SSL;
$smtp->command('STARTTLS');
$smtp->response();
next reply other threads:[~2009-09-25 21:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-25 21:30 iler.ml [this message]
2009-09-25 21:34 ` [PATCH] fix obscure perl message when encryption=tls and smtp cannot connect Shawn O. Pearce
2009-09-25 21:39 ` Yakov Lerner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1253914213-22274-1-git-send-email-iler.ml@gmail.com \
--to=iler.ml@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).