Git development
 help / color / mirror / Atom feed
From: Stephen Boyd <bebarino@gmail.com>
To: Jeff King <peff@peff.net>
Cc: Petter Urkedal <urkedal@nbi.dk>, git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH] Reserve a slot for argv[0] in default_arg.
Date: Sun, 04 Oct 2009 13:02:21 -0700	[thread overview]
Message-ID: <1254686541.507.9.camel@swboyd-laptop> (raw)
In-Reply-To: <20091004182746.GA22995@coredump.intra.peff.net>

On Sun, 2009-10-04 at 14:27 -0400, Jeff King wrote:
> 
> Ah, thanks, for some reason I wasn't able to produce it before, but I
> can easily replicate it here. I think it's a regression from converting
> show-branch to use parse_options, which happened in May, but I didn't
> actually bisect it. I'm not sure showbranch.default has worked at all
> since then (which I guess goes to show how many people are actually
> using it).

Correct. Junio sent a patch to fix this problem in June[1]. I guess he
must have dropped his own patch, or he wasn't satisfied with how parse
options clobbers things.

[1] http://article.gmane.org/gmane.comp.version-control.git/121142

  reply	other threads:[~2009-10-04 20:06 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-03 13:29 [PATCH] Reserve a slot for argv[0] in default_arg Petter Urkedal
2009-10-04 13:33 ` Jeff King
2009-10-04 14:13   ` Petter Urkedal
2009-10-04 18:27     ` Jeff King
2009-10-04 20:02       ` Stephen Boyd [this message]
2009-10-04 22:20       ` Junio C Hamano
2009-10-05  6:36         ` Petter Urkedal
2009-10-05 18:45           ` Jeff King
2009-10-05  6:44       ` Petter Urkedal
2009-10-04 14:51   ` Petter Urkedal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1254686541.507.9.camel@swboyd-laptop \
    --to=bebarino@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=peff@peff.net \
    --cc=urkedal@nbi.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox