From: Joe Perches <joe@perches.com>
To: git@vger.kernel.org
Cc: Jay Soffian <jaysoffian@gmail.com>
Subject: [PATCH] git-send-email.perl: Fold long header lines to 78 chars
Date: Mon, 05 Oct 2009 09:24:58 -0700 [thread overview]
Message-ID: <1254759898.1799.449.camel@Joe-Laptop.home> (raw)
Some MTAs reject or filter long header lines which can
be generated if the cc list is only a few entries.
Fold long header lines to 78 chars to be more rfc compliant.
Signed-off-by: Joe Perches <joe@perches.com>
diff --git a/git-send-email.perl b/git-send-email.perl
index dd821f7..cb8b48b 100755
--- a/git-send-email.perl
+++ b/git-send-email.perl
@@ -814,6 +814,41 @@ sub sanitize_address
}
+# Fold header lines to 78 chars if possible for better RFC 2822 compliance
+# Does not terminate last line with newline
+sub fold_header
+{
+ my ($folded_line, $separator, @entries) = @_;
+ my $folded_header = "";
+ my $count = 0;
+ my $trim_sep = $separator;
+
+ $trim_sep =~ s/\s+$//;
+
+ foreach my $entry (@entries) {
+ if ($count == 0) {
+ $folded_line = "$folded_line$entry";
+ } elsif ((length($folded_line) + length($entry)) > 78) {
+ if ($folded_header ne "") {
+ $folded_header = "$folded_header$trim_sep\n";
+ }
+ $folded_header = "$folded_header$folded_line";
+ $folded_line = " $entry";
+ } else {
+ $folded_line = "$folded_line$separator$entry";
+ }
+ $count++;
+ }
+
+ if ($count == 0) {
+ $folded_header = "$folded_line";
+ } else {
+ $folded_header = "$folded_header$trim_sep\n$folded_line";
+ }
+
+ return "$folded_header";
+}
+
# Returns 1 if the message was sent, and 0 otherwise.
# In actuality, the whole program dies when there
# is an error sending a message.
@@ -835,10 +870,10 @@ sub send_message
$gitversion = Git::version();
}
- my $cc = join(", ", unique_email_list(@cc));
+ @cc = unique_email_list(@cc);
my $ccline = "";
- if ($cc ne '') {
- $ccline = "\nCc: $cc";
+ if (@cc gt 0) {
+ $ccline = fold_header("\nCc: ", ", ", @cc);
}
my $sanitized_sender = sanitize_address($sender);
make_message_id() unless defined($message_id);
@@ -976,7 +1011,7 @@ X-Mailer: git-send-email $gitversion
if ($smtp_server !~ m#^/#) {
print "Server: $smtp_server\n";
print "MAIL FROM:<$raw_from>\n";
- print "RCPT TO:".join(',',(map { "<$_>" } @recipients))."\n";
+ print fold_header("RCPT TO:", ",", map { "<$_>" } @recipients)."\n";
} else {
print "Sendmail: $smtp_server ".join(' ',@sendmail_parameters)."\n";
}
next reply other threads:[~2009-10-05 16:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-05 16:24 Joe Perches [this message]
2009-10-08 5:02 ` [PATCH] git-send-email.perl: Fold long header lines to 78 chars Junio C Hamano
2009-10-08 5:28 ` Joe Perches
2009-10-08 16:27 ` Junio C Hamano
2009-10-08 17:03 ` [PATCH v2] git-send-email.perl: fold multiple entry "Cc:" and multiple single line "RCPT TO:"s Joe Perches
2009-10-09 6:50 ` Junio C Hamano
2009-10-10 0:57 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1254759898.1799.449.camel@Joe-Laptop.home \
--to=joe@perches.com \
--cc=git@vger.kernel.org \
--cc=jaysoffian@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).