* [RFC/PATCH] gitweb: linkify author/committer names with search
@ 2009-10-12 6:19 Stephen Boyd
2009-10-12 23:42 ` Junio C Hamano
2009-10-13 10:26 ` Giuseppe Bilotta
0 siblings, 2 replies; 7+ messages in thread
From: Stephen Boyd @ 2009-10-12 6:19 UTC (permalink / raw)
To: git; +Cc: Jakub Narebski
It's nice to search for an author by merely clicking on their name in
gitweb. This is usually faster than selecting the name, copying the
selection, pasting it into the search box, selecting between
author/committer and then hitting enter.
Signed-off-by: Stephen Boyd <bebarino@gmail.com>
---
Cc'ed Jakub as he seems to be resident gitweb expert.
I thought this might be a nice addition.
The problem is I can't get it to work with UTF-8 characters. I'm not sure
if it's my system or not, so I'm just posting here to see if others
experience the same problem and if there's interest.
gitweb/gitweb.perl | 18 ++++++++++++++----
1 files changed, 14 insertions(+), 4 deletions(-)
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index 24b2193..349e734 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -1604,7 +1604,10 @@ sub format_author_html {
my $author = chop_and_escape_str($co->{'author_name'}, @_);
return "<$tag class=\"author\">" .
git_get_avatar($co->{'author_email'}, -pad_after => 1) .
- $author . "</$tag>";
+ $cgi->a({-href => href(action=>"search", hash=>$hash,
+ searchtext=>$co->{'author_name'},
+ searchtype=>"author"), class=>"list"}, $author) .
+ "</$tag>";
}
# format git diff header line, i.e. "diff --(git|combined|cc) ..."
@@ -3373,10 +3376,13 @@ sub git_print_authorship {
my $co = shift;
my %opts = @_;
my $tag = $opts{-tag} || 'div';
+ my $author = $co->{'author_name'};
my %ad = parse_date($co->{'author_epoch'}, $co->{'author_tz'});
print "<$tag class=\"author_date\">" .
- esc_html($co->{'author_name'}) .
+ $cgi->a({-href => href(action=>"search", searchtext=>$author,
+ searchtype=>"author"), class=>"list"},
+ esc_html($author)) .
" [$ad{'rfc2822'}";
print_local_time(%ad) if ($opts{-localtime});
print "]" . git_get_avatar($co->{'author_email'}, -pad_before => 1)
@@ -3395,8 +3401,12 @@ sub git_print_authorship_rows {
@people = ('author', 'committer') unless @people;
foreach my $who (@people) {
my %wd = parse_date($co->{"${who}_epoch"}, $co->{"${who}_tz"});
- print "<tr><td>$who</td><td>" . esc_html($co->{$who}) . "</td>" .
- "<td rowspan=\"2\">" .
+ print "<tr><td>$who</td><td>" .
+ $cgi->a({-href => href(action=>"search",
+ searchtext=>$co->{"${who}_name"},
+ searchtype=>$who), class=>"list"},
+ esc_html($co->{$who})) .
+ "</td><td rowspan=\"2\">" .
git_get_avatar($co->{"${who}_email"}, -size => 'double') .
"</td></tr>\n" .
"<tr>" .
--
1.6.5.1.g53fd
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [RFC/PATCH] gitweb: linkify author/committer names with search
2009-10-12 6:19 [RFC/PATCH] gitweb: linkify author/committer names with search Stephen Boyd
@ 2009-10-12 23:42 ` Junio C Hamano
2009-10-13 0:31 ` Stephen Boyd
2009-10-13 10:26 ` Giuseppe Bilotta
1 sibling, 1 reply; 7+ messages in thread
From: Junio C Hamano @ 2009-10-12 23:42 UTC (permalink / raw)
To: Stephen Boyd; +Cc: git, Jakub Narebski
Stephen Boyd <bebarino@gmail.com> writes:
> It's nice to search for an author by merely clicking on their name in
> gitweb. This is usually faster than selecting the name, copying the
> selection, pasting it into the search box, selecting between
> author/committer and then hitting enter.
The intent makes sense to me, although I somehow suspect that with avatar
support the user might be tempted to click on the icon not necessarily on
the name string.
> Signed-off-by: Stephen Boyd <bebarino@gmail.com>
> ---
>
> Cc'ed Jakub as he seems to be resident gitweb expert.
>
> I thought this might be a nice addition.
>
> The problem is I can't get it to work with UTF-8 characters. I'm not sure
> if it's my system or not, so I'm just posting here to see if others
> experience the same problem and if there's interest.
>
> gitweb/gitweb.perl | 18 ++++++++++++++----
> 1 files changed, 14 insertions(+), 4 deletions(-)
>
> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
> index 24b2193..349e734 100755
> --- a/gitweb/gitweb.perl
> +++ b/gitweb/gitweb.perl
> @@ -1604,7 +1604,10 @@ sub format_author_html {
> my $author = chop_and_escape_str($co->{'author_name'}, @_);
> return "<$tag class=\"author\">" .
> git_get_avatar($co->{'author_email'}, -pad_after => 1) .
> - $author . "</$tag>";
> + $cgi->a({-href => href(action=>"search", hash=>$hash,
> + searchtext=>$co->{'author_name'},
> + searchtype=>"author"), class=>"list"}, $author) .
> + "</$tag>";
> }
>
> # format git diff header line, i.e. "diff --(git|combined|cc) ..."
> @@ -3373,10 +3376,13 @@ sub git_print_authorship {
> my $co = shift;
> my %opts = @_;
> my $tag = $opts{-tag} || 'div';
> + my $author = $co->{'author_name'};
>
> my %ad = parse_date($co->{'author_epoch'}, $co->{'author_tz'});
> print "<$tag class=\"author_date\">" .
> - esc_html($co->{'author_name'}) .
> + $cgi->a({-href => href(action=>"search", searchtext=>$author,
> + searchtype=>"author"), class=>"list"},
> + esc_html($author)) .
> " [$ad{'rfc2822'}";
> print_local_time(%ad) if ($opts{-localtime});
> print "]" . git_get_avatar($co->{'author_email'}, -pad_before => 1)
> @@ -3395,8 +3401,12 @@ sub git_print_authorship_rows {
> @people = ('author', 'committer') unless @people;
> foreach my $who (@people) {
> my %wd = parse_date($co->{"${who}_epoch"}, $co->{"${who}_tz"});
> - print "<tr><td>$who</td><td>" . esc_html($co->{$who}) . "</td>" .
> - "<td rowspan=\"2\">" .
> + print "<tr><td>$who</td><td>" .
> + $cgi->a({-href => href(action=>"search",
> + searchtext=>$co->{"${who}_name"},
> + searchtype=>$who), class=>"list"},
> + esc_html($co->{$who})) .
> + "</td><td rowspan=\"2\">" .
> git_get_avatar($co->{"${who}_email"}, -size => 'double') .
> "</td></tr>\n" .
> "<tr>" .
> --
> 1.6.5.1.g53fd
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [RFC/PATCH] gitweb: linkify author/committer names with search
2009-10-12 6:19 [RFC/PATCH] gitweb: linkify author/committer names with search Stephen Boyd
2009-10-12 23:42 ` Junio C Hamano
@ 2009-10-13 10:26 ` Giuseppe Bilotta
2009-10-13 18:39 ` Stephen Boyd
1 sibling, 1 reply; 7+ messages in thread
From: Giuseppe Bilotta @ 2009-10-13 10:26 UTC (permalink / raw)
To: git; +Cc: Giuseppe Bilotta, Stephen Boyd, Jakub Narebski
On Monday 12 October 2009 08:19, Stephen Boyd wrote:
> The problem is I can't get it to work with UTF-8 characters. I'm not sure
> if it's my system or not, so I'm just posting here to see if others
> experience the same problem and if there's interest.
Does it work if you use CGI::escape() on the author names when filling
the searchtext?
--
Giuseppe "Oblomov" Bilotta
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [RFC/PATCH] gitweb: linkify author/committer names with search
2009-10-13 10:26 ` Giuseppe Bilotta
@ 2009-10-13 18:39 ` Stephen Boyd
2009-10-13 19:41 ` Giuseppe Bilotta
0 siblings, 1 reply; 7+ messages in thread
From: Stephen Boyd @ 2009-10-13 18:39 UTC (permalink / raw)
To: Giuseppe Bilotta; +Cc: git, Jakub Narebski
Giuseppe Bilotta wrote:
> On Monday 12 October 2009 08:19, Stephen Boyd wrote:
>> The problem is I can't get it to work with UTF-8 characters. I'm not sure
>> if it's my system or not, so I'm just posting here to see if others
>> experience the same problem and if there's interest.
>
> Does it work if you use CGI::escape() on the author names when filling
> the searchtext?
This doesn't seem to work. Now I get %25 in front of the escaped
characters. For example, a space is now %25%20.
Can you reproduce my problem locally?
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [RFC/PATCH] gitweb: linkify author/committer names with search
2009-10-13 18:39 ` Stephen Boyd
@ 2009-10-13 19:41 ` Giuseppe Bilotta
2009-10-13 20:16 ` Stephen Boyd
0 siblings, 1 reply; 7+ messages in thread
From: Giuseppe Bilotta @ 2009-10-13 19:41 UTC (permalink / raw)
To: Stephen Boyd; +Cc: git, Jakub Narebski
On Tue, Oct 13, 2009 at 8:39 PM, Stephen Boyd <bebarino@gmail.com> wrote:
> Giuseppe Bilotta wrote:
>> On Monday 12 October 2009 08:19, Stephen Boyd wrote:
>>> The problem is I can't get it to work with UTF-8 characters. I'm not sure
>>> if it's my system or not, so I'm just posting here to see if others
>>> experience the same problem and if there's interest.
>>
>> Does it work if you use CGI::escape() on the author names when filling
>> the searchtext?
>
> This doesn't seem to work. Now I get %25 in front of the escaped
> characters. For example, a space is now %25%20.
>
> Can you reproduce my problem locally?
Reproduced, debugged, patch incoming (the problem is not in your patch
but in esc_param).
--
Giuseppe "Oblomov" Bilotta
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [RFC/PATCH] gitweb: linkify author/committer names with search
2009-10-13 19:41 ` Giuseppe Bilotta
@ 2009-10-13 20:16 ` Stephen Boyd
0 siblings, 0 replies; 7+ messages in thread
From: Stephen Boyd @ 2009-10-13 20:16 UTC (permalink / raw)
To: Giuseppe Bilotta; +Cc: git, Jakub Narebski
On Tue, Oct 13, 2009 at 12:41 PM, Giuseppe Bilotta
<giuseppe.bilotta@gmail.com> wrote:
>
> Reproduced, debugged, patch incoming (the problem is not in your patch
> but in esc_param).
>
Thanks. I will test later today. I think a similar problem affects the
branch name labels (the colored boxes with ref names in them) when the
name has utf8 characters.
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2009-10-13 20:26 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-10-12 6:19 [RFC/PATCH] gitweb: linkify author/committer names with search Stephen Boyd
2009-10-12 23:42 ` Junio C Hamano
2009-10-13 0:31 ` Stephen Boyd
2009-10-13 10:26 ` Giuseppe Bilotta
2009-10-13 18:39 ` Stephen Boyd
2009-10-13 19:41 ` Giuseppe Bilotta
2009-10-13 20:16 ` Stephen Boyd
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).